Skip to content

Add razor-compiler patch to fix source-build bootstrap build #14379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MichaelSimons merged 1 commit into from
Aug 24, 2022
Merged

Add razor-compiler patch to fix source-build bootstrap build #14379

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions ...compiler/0001-Add-NoWarn-for-NU1507.patch → ...hes/razor-compiler/0001-Add-NoWarns.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,14 @@
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
From: Logan Bussell <[email protected]>
Date: Fri, 13 May 2022 16:14:14 -0700
Subject: [PATCH] Add NoWarn for NU1507
Subject: [PATCH] Add NoWarns

This warning occurs when using NuGet central package management without defining
NU1507 - This warning occurs when using NuGet central package management without defining
any Package Source Mappings.
NU1605 - Detected package downgrade: System.Memory from 4.5.5 to 4.5.4

Workaround for: https://github.com/dotnet/razor-compiler/issues/242
Backport: NU1507 - https://github.com/dotnet/razor-compiler/issues/242
Backport: NU1605 - https://github.com/dotnet/source-build/issues/2973
---
Directory.Build.props | 1 +
1 file changed, 1 insertion(+)
Expand All @@ -19,7 +21,7 @@ index a57125f5..019ac376 100644
<!-- Ensure API docs are available. -->
<NoWarn>$(NoWarn.Replace('1591', ''))</NoWarn>
<NoWarn Condition=" '$(BuildingInsideVisualStudio)' == 'true' ">$(NoWarn);0105</NoWarn>
+ <NoWarn>$(NoWarn);NU1507</NoWarn>
+ <NoWarn>$(NoWarn);NU1507;NU1605</NoWarn>

<!-- For local builds, don't make missing XML docs a fatal build error, but still surface so we have visibility into undocumented APIs. -->
<WarningsNotAsErrors Condition=" '$(ContinuousIntegrationBuild)' != 'true' ">$(WarningsNotAsErrors);CS1591</WarningsNotAsErrors>