Adding ppc64le arch in sourcebuild props #14575
Conversation
|
|
|
Adding the patch changes manually for .NET7 |
|
@omajid Could you please review. Thanks |
| maccatalyst-x64; | ||
| maccatalyst-arm64; | ||
| linux-s390x; | ||
| linux-ppc64le; |
There was a problem hiding this comment.
These should be added to Net70AppHostRids/Net70RuntimePackRids, right? Do we really want to modify the set of architectures in .NET 6?
There was a problem hiding this comment.
I agree. This should be added to Net70AppHostRids/Net70RuntimePackRids
| <AspNetCoreRuntimePackRids Include="@(AspNetCore50RuntimePackRids);osx-arm64;linux-s390x" /> | ||
| <AspNetCoreRuntimePackRids Include="@(AspNetCore50RuntimePackRids);osx-arm64" /> | ||
| <AspNetCore60RuntimePackRids Include="@(AspNetCore50RuntimePackRids);osx-arm64;linux-s390x" /> | ||
| <AspNetCore70RuntimePackRids Include="@(AspNetCore50RuntimePackRids);osx-arm64;linux-s390x;linux-ppc64le" /> |
There was a problem hiding this comment.
| <AspNetCore70RuntimePackRids Include="@(AspNetCore50RuntimePackRids);osx-arm64;linux-s390x;linux-ppc64le" /> | |
| <AspNetCore70RuntimePackRids Include="@(AspNetCore60RuntimePackRids);linux-ppc64le" /> |
There was a problem hiding this comment.
Updated as per suggestion, please check.
| <AspNetCore31RuntimePackRids Include="@(AspNetCore30RuntimePackRids)" /> | ||
| <AspNetCore50RuntimePackRids Include="@(AspNetCore31RuntimePackRids);linux-musl-arm;win-arm64" /> | ||
| <AspNetCoreRuntimePackRids Include="@(AspNetCore50RuntimePackRids);osx-arm64;linux-s390x" /> | ||
| <AspNetCoreRuntimePackRids Include="@(AspNetCore50RuntimePackRids);osx-arm64" /> |
There was a problem hiding this comment.
I think we can delete this line now?
There was a problem hiding this comment.
I haven't deleted it as this variable is used in KnownFrameworkReference for net8.0
There was a problem hiding this comment.
We need someone from Microsoft to chime in on this change - this is not just a change for ppc64le
There was a problem hiding this comment.
I haven't deleted it as this variable is used in KnownFrameworkReference for net8.0
In that case, perhaps this should mean AspNetCore80RuntimePackRids? And inherit from 70?
There was a problem hiding this comment.
@omajid Added AspNetCore80RuntimePackRids inherited from 70, please check
|
cc @dotnet/source-build-internal |
|
Created #14617 for the same changes, recreated PR because fork was messed up. Apologies. |
5 participants
Added ppc64le arch in required files for source build