Fix source-build CI to not run tarball build when tarball creation fails #14678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelSimons
force-pushed
the
tarball-ci-fix
branch
from
42a6b92 to
03dfcd6
Compare
lbussell
reviewed
Oct 10, 2022
| # Always attempt to run the bootstrap leg (e.g. even when stage 1 tests fail) in order to get a complete accessment of the build status. | ||
| # The bootstrap build will shortcut if the stage 1 build failed. | ||
| condition: and(${{ parameters.condition }}, succeededOrFailed()) | ||
| condition: succeededOrFailed() |
Member
There was a problem hiding this comment.
Would we want succeeded() instead of succeededOrFailed()? It looks to me like succeededOrFailed() will run every time regardless of the dependsOn.
Member
There was a problem hiding this comment.
Member
Author
There was a problem hiding this comment.
See the above comment. We want to try to run the bootstrap leg even when the stage 1 matrix does not completely pass. If one distro fails or a unit test fails, we should still try to run the bootstrap leg in order to get a complete assessment on the built.
There was a problem hiding this comment.
I think this is fine based on the comment above. Bootstrapping should fail quite early if we don't even have a tarball or something.
crummel
approved these changes
Oct 10, 2022
| # Always attempt to run the bootstrap leg (e.g. even when stage 1 tests fail) in order to get a complete accessment of the build status. | ||
| # The bootstrap build will shortcut if the stage 1 build failed. | ||
| condition: and(${{ parameters.condition }}, succeededOrFailed()) | ||
| condition: succeededOrFailed() |
There was a problem hiding this comment.
I think this is fine based on the comment above. Bootstrapping should fail quite early if we don't even have a tarball or something.
crummel
approved these changes
Oct 10, 2022
lbussell
approved these changes
Oct 10, 2022
MichaelSimons
added a commit
to MichaelSimons/installer
that referenced
this pull request
Oct 11, 2022
…ils (dotnet#14678) * Fix source-build CI to not run tarball build when tarball creation failed * Bad fix * Revert test patch
MichaelSimons
added a commit
that referenced
this pull request
Oct 12, 2022
* [release/6.0.1xx] Enable online and offline source-build tarball build in all PRs (#14711) * Enable online and offline source-build tarball build in all PRs (#14620) * Fix source-build CI to not run tarball build when tarball creation fails (#14678) * Fix source-build CI to not run tarball build when tarball creation failed * Bad fix * Revert test patch * update global.json and Versions.props for .NET SDK 6.0.110 (#14717) * [release/6.0.1xx] Re-write dotnet-watch smoke test (#14367) * Re-write dotnet-watch smoke test * Revert async changes * Disable source-build tarball validation for non 6.0.1xx legs Co-authored-by: Michael Simons <[email protected]> Co-authored-by: NET Source-Build Bot <[email protected]> Co-authored-by: Logan Bussell <[email protected]> Co-authored-by: Jason Zhai <[email protected]>
MichaelSimons
added a commit
that referenced
this pull request
Oct 13, 2022
* [automated] Merge branch 'release/6.0.1xx' => 'release/6.0.3xx' (#14726) * [release/6.0.1xx] Enable online and offline source-build tarball build in all PRs (#14711) * Enable online and offline source-build tarball build in all PRs (#14620) * Fix source-build CI to not run tarball build when tarball creation fails (#14678) * Fix source-build CI to not run tarball build when tarball creation failed * Bad fix * Revert test patch * update global.json and Versions.props for .NET SDK 6.0.110 (#14717) * [release/6.0.1xx] Re-write dotnet-watch smoke test (#14367) * Re-write dotnet-watch smoke test * Revert async changes * Disable source-build tarball validation for non 6.0.1xx legs Co-authored-by: Michael Simons <[email protected]> Co-authored-by: NET Source-Build Bot <[email protected]> Co-authored-by: Logan Bussell <[email protected]> Co-authored-by: Jason Zhai <[email protected]> * Update asp.net templates (#14687) * Update asp.net templates (#14688) Co-authored-by: Michael Simons <[email protected]> Co-authored-by: NET Source-Build Bot <[email protected]> Co-authored-by: Logan Bussell <[email protected]> Co-authored-by: Jason Zhai <[email protected]> Co-authored-by: Marc Paine <[email protected]> Co-authored-by: William Godbe <[email protected]> Co-authored-by: v-wuzhai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in #14620 regressed the tarball build CI. It was getting run even when tarball creation failed. This can be seen by looking at the checks run for the first commit of #14670.