-
Notifications
You must be signed in to change notification settings - Fork 437
Get source-build main building #14790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
[Triage] Since the fixes require #14549, it would be best to combine the PRs. Please limit the changes to the minimum set needed. |
@MichaelSimons I'm wondering why you are not reviewing and merging #14549? It has green CI. |
Tarball CI was disabled in main - see dotnet/source-build#3026. #14549 having green CI is not telling us anything. On one hand I don't object to merging it since it was validated in 7.0 but on the other hand it would be nice to have a working source-build before merging to properly validate. If folks have an opinion please voice it. |
ee9b92d to
22de1b0
Compare
ddf3b4f to
b8c1efd
Compare
|
This is ready for review. |
|
Source-build leg passed, OSX leg appear hung. Merging. |
This PR includes the following changes: