source-build: stop overriding aspnetcore version

[tmds]

Rename MicrosoftAspNetCoreAppRuntimePackageVersion so existing Artifacts tarballs don't override it,
and stop adding it to the PackageVersions.props in new Artifacts tarballs.

Related to dotnet/source-build#3121.

cc @ayakael @MichaelSimons @crummel

[MichaelSimons]

My understanding is the renamed property is temporary until the previous source-build artifacts have been updated to not include the extra property in the PackageVersions.props file. Given the rename affects the official source and is not very localized, what do you think about adding a call to ReplaceRegexInFiles to simply remove the extra property in the PackageVersions.props file? This will validate the end state we want to get to works as expected now. This could be done where we copy the file into the artifacts.

[tmds]

what do you think about adding a call to ReplaceRegexInFiles to simply remove the extra property in the PackageVersions.props file? This will validate the end state we want to get to works as expected now. This could be done where we copy the file into the artifacts.

I've implemented this. I had to move the ReplaceRegexInFiles after BuildXPlatTasks to be able to use the task.

[MichaelSimons]

LGTM - Thanks for refactoring to limit the impact of the temporary workaround. I have one minor comment.

[tmds]

@ayakael do you want to verify the patch works with the Alpine build?

[ayakael]

@ayakael do you want to verify the patch works with the Alpine build?

Sure, I'll do that right away.

[ayakael]

@tmds Testing against 7.0.100-rtm.22521.12, Alpine looks good. I'll update release/6.0 backport :))