Avoid missing signing files in zips #14966
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeloff
approved these changes
Nov 11, 2022
dougbu
reviewed
Nov 11, 2022
eng/Signing.props
Outdated
Comment on lines
10
to
12
| <ItemsToSign Include="$(ArtifactsPackagesDir)*.exe" /> | ||
| <ItemsToSign Include="$(ArtifactsPackagesDir)*.zip" /> | ||
| <ItemsToSign Include="$(ArtifactsPackagesDir)*.msi" /> |
dougbu
approved these changes
Nov 11, 2022
| <ItemsToSign Include="$(ArtifactsNonShippingPackagesDir)*.msi" /> | ||
| <ItemsToSign Include="$(ArtifactsNonShippingPackagesDir)*.zip" Condition=" '$(PublishBinariesAndBadge)' == 'true' " /> | ||
| <ItemsToSign Include="$(ArtifactsPackagesDir)**\*.wixpack.zip" /> | ||
| <ItemsToSign Include="$(ArtifactsPackagesDir)**\*.exe" /> |
There was a problem hiding this comment.
Just also noticed the $(ArtifactsNonShippingPackagesDir)*.exe files were specifically excluded before. Doesn't hurt much to sign them (if any exist) of course.
Member
Author
There was a problem hiding this comment.
They weren't excluded. There just weren't any so they weren't added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.