[release/7.0.1xx] repos/sdk.proj: set NativeAotSupported=false on arm platform #15039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayakael
force-pushed
the
fix-arm-build
branch
from
603eee3 to
67c497a
Compare
ayakael
changed the title
16 tasks
Author
|
dotnet/sdk#28674 is slated for inclusion on 7.0.3. As this PR requires the latter to work, we should aim for merge after 7.0.2 is released. |
crummel
approved these changes
Jan 12, 2023
|
@marcpopMSFT This is related to dotnet/sdk#28674, should it go through tactics separately or can we just merge it after that's in? |
Member
|
@crummel are these essentially both required and do you recall if the tactics approval covered both? Could be worth an email to tactics just in case as I don't remember. |
|
Sent the tactics email. |
|
Approved by tactics, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just like on mono-flavored runtime,
armdoes not support NativeAot. Thus, when building on that platform, the build fails when building on itself assdklooks forMicrosoft.DotNet.ILCompilerwhen it is never produced by runtime.Piggy-backing off of dotnet/sdk#28674, fix by setting
NativeAotSupported=falsewhen building source-build onarm.