-
Notifications
You must be signed in to change notification settings - Fork 437
Use VMR instead of the tarball for Source-Build builds #15042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit eeb75f4f188fce979f7da67eb3f9d0843428cc51.
|
@MichaelSimons TLDR of my today's attempts + status quo:
|
It looks better. Given the AzDO limitations I think your approach is good and we should go with it.
I think it should be removed.
Per our conversation, I agree is should be commented out with a note that the vmr-synchronization stage is necessary if the source-build leg is disabled. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
231a918 to
da962a2
Compare
Changes to CI
For PRs, the Source-Build leg that was running inside of the Build stage is now moved to a separate stage but runs more or less the same: https://dev.azure.com/dnceng-public/public/_build/results?buildId=97509&view=results
Instead of creating the tarball, we are building the
dotnet/dotnetrepo there.For internal rolling builds, we are taking this pipeline and merging it into
dotnet-installer-official-ci.So it's one extra stage that runs pretty quick (faster than the Build stage by far).
It won't be creating and pushing the tarball artifact anymore though.
Once the rolling build is finished, there won't be no more source-build-build pipeline but instead dotnet-dotnet-official-ci which will build the dotnet/dotnet repo again instead of the tarball that was originally produced from the rolling build.
The MSFT SDK from the installer build will still be consumed by it though.
More details dotnet/arcade#10677
Example builds
dotnet-dotnet-source-build(internal rolling) - https://dev.azure.com/dnceng/internal/_build/results?buildId=2054513dotnet-installer-official-ci(manual run) - https://dev.azure.com/dnceng/internal/_build/results?buildId=2054548(runs the whole matrix as opposed to the PR build)
dotnet-installer-official-cirolling build will only run the VMR synchronization stage outside of what it does nowdotnet-installerbuild will not run any extra steps as compared to today'sTo discuss in the PR
vmr-source-build.yml(pipeline/stage/job/steps). I am open to something different, just don't know what that is.