[main] Update dependencies from dotnet/arcade

[dotnet-maestro]

This pull request updates the following dependencies

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

• Coherency Updates:
  • Microsoft.SourceLink.GitHub: from 1.2.0-beta-22518-02 to 1.2.0-beta-23064-02 (parent: Microsoft.DotNet.Arcade.Sdk)
  • Microsoft.DotNet.XliffTasks: from 1.0.0-beta.22631.1 to 1.0.0-beta.23064.1 (parent: Microsoft.DotNet.Arcade.Sdk)

From https://github.com/dotnet/arcade

• Subscription: 7787dd03-cbf4-4297-391c-08d8e9750bf8
• Build: 20230116.1
• Date Produced: January 16, 2023 1:41:18 PM UTC
• Commit: e52b885a6ec2fc87c9e94b80d9ff7a862786390b
• Branch: refs/heads/main

• Updates:
  • Microsoft.DotNet.Arcade.Sdk: from 8.0.0-beta.23052.2 to 8.0.0-beta.23066.1
  • Microsoft.DotNet.Build.Tasks.Installers: from 8.0.0-beta.23052.2 to 8.0.0-beta.23066.1
  • Microsoft.DotNet.CMake.Sdk: from 8.0.0-beta.23052.2 to 8.0.0-beta.23066.1
  • Microsoft.SourceLink.GitHub: from 1.2.0-beta-22518-02 to 1.2.0-beta-23064-02
  • Microsoft.DotNet.XliffTasks: from 1.0.0-beta.22631.1 to 1.0.0-beta.23064.1

[dsplaisted]

@dotnet/source-build-internal Could someone look at this source build failure?

/__w/1/s/artifacts/source-build/self/src/src/redist/targets/GenerateLayout.targets(391,5): error : Download from all targets failed. List of attempted targets: https://dotnetcli.blob.core.windows.net/dotnet//dotnet-runtime-8.0.0-alpha.1.22605.1-linux-x64.tar.gz, https://dotnetbuilds.blob.core.windows.net/public//dotnet-runtime-8.0.0-alpha.1.22605.1-linux-x64.tar.gz [/__w/1/s/artifacts/source-build/self/src/src/redist/redist.csproj]
##[error]artifacts/source-build/self/src/src/redist/targets/GenerateLayout.targets(391,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) Download from all targets failed. List of attempted targets: https://dotnetcli.blob.core.windows.net/dotnet//dotnet-runtime-8.0.0-alpha.1.22605.1-linux-x64.tar.gz, https://dotnetbuilds.blob.core.windows.net/public//dotnet-runtime-8.0.0-alpha.1.22605.1-linux-x64.tar.gz
/__w/1/s/artifacts/source-build/self/src/src/redist/targets/GenerateLayout.targets(391,5): error : Failed to download file using addresses in Uri and/or Uris. [/__w/1/s/artifacts/source-build/self/src/src/redist/redist.csproj]

[MichaelSimons]

https://github.com/orgs/dotnet/teams/source-build-internal Could someone look at this source build failure?

FYI, the source-build (managed) legs are the responsibility of the repo owners to maintain, not the source-build team. We are happy to help out if there are complications if the repo owners can't diagnose.

[marcpopMSFT]

It's failing to find the linux version of the runtime:
/__w/1/s/artifacts/source-build/self/src/src/redist/targets/GenerateLayout.targets(391,5): error : Download from all targets failed. List of attempted targets: https://dotnetcli.blob.core.windows.net/dotnet//dotnet-runtime-8.0.0-alpha.1.22605.1-linux-x64.tar.gz, https://dotnetbuilds.blob.core.windows.net/public//dotnet-runtime-8.0.0-alpha.1.22605.1-linux-x64.tar.gz [/__w/1/s/artifacts/source-build/self/src/src/redist/redist.csproj] ##[error]artifacts/source-build/self/src/src/redist/targets/GenerateLayout.targets(391,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) Download from all targets failed. List of attempted targets: https://dotnetcli.blob.core.windows.net/dotnet//dotnet-runtime-8.0.0-alpha.1.22605.1-linux-x64.tar.gz, https://dotnetbuilds.blob.core.windows.net/public//dotnet-runtime-8.0.0-alpha.1.22605.1-linux-x64.tar.gz

Is that a networking issue or a problem with the arcade update itself?

[crummel]

I'm taking a look at this now.

[nagilson]

@crummel PTAL again once you're back

[MichaelSimons]

Some runtime changes are needed to unblock this. I merged these changes in with #15151.

[MichaelSimons]

@crummel - I resolved the merge conflicts. There is a sourcelink build issue. Can you please investigate and pull in the appropriate folks as needed?

[mmitche]

/cc @ViktorHofer This includes the 8.0 arcade update.

[ViktorHofer]

Fixed the failing Windows build which hardcoded the TFM of the Microsoft.DotNet.Build.Tasks.Installers package.

[ViktorHofer]

We will be able to remove the attached patch in ~2 hours when the Arcade dependency update is available.

[premun]

We will be able to remove the attached patch in ~2 hours when the Arcade dependency update is available.

Would we skip arcade validation? Otherwise I am not sure 2 hours is possible.

cc @premun Premek Vysoky FTE - We got a weird CI error with the patch I added:

Thanks for notifying me. A fix is coming in about an hour from arcade-services.

[ViktorHofer]

Would we skip arcade validation? Otherwise I am not sure 2 hours is possible.

Yes, the Arcade.Sdk package will be available on the feed when the normal official build completes. There's no need to wait for the validation pipeline to finish in this case. I will manually update the Arcade.Sdk version used in this branch as soon as the package is available.

[ViktorHofer]

Another build break :( Will be fixed with dotnet/arcade#12208

[crummel]

@mmitche This might be related to your recent change?

.nuget/packages/microsoft.dotnet.arcade.sdk/8.0.0-beta.23063.3/tools/DefaultVersions.props(15,3): error MSB4024: (NETCORE_ENGINEERING_TELEMETRY=Restore) The imported project file "/Users/runner/work/1/s/.nuget/packages/microsoft.dotnet.arcade.sdk/8.0.0-beta.23063.3/tools/DefaultVersions.Generated.props" could not be loaded. The 'MicrosoftSourceLinkVersion' start tag on line 10 position 6 does not match the end tag of 'MicrosoftSourceLinkGitVersion'. Line 10, position 54.

I'm looking at the new VMR failure (the ICommandHandler error).

[ViktorHofer]

Yes there was yet another issue. Will be fixed with dotnet/arcade#12211

[crummel]

@tmat I'm not seeing that ICommandHandler has changed recently but we're getting

    /vmr/dotnet/src/sourcelink/artifacts/source-build/self/src/src/dotnet-sourcelink/Program.cs(79,28): error CS7069: Reference to type 'ICommandHandler' claims it is defined in 'System.CommandLine', but it could not be found [/vmr/dotnet/src/sourcelink/artifacts/source-build/self/src/src/dotnet-sourcelink/dotnet-sourcelink.csproj::TargetFramework=net7.0]
    /vmr/dotnet/src/sourcelink/artifacts/source-build/self/src/src/dotnet-sourcelink/Program.cs(85,33): error CS7069: Reference to type 'ICommandHandler' claims it is defined in 'System.CommandLine', but it could not be found [/vmr/dotnet/src/sourcelink/artifacts/source-build/self/src/src/dotnet-sourcelink/dotnet-sourcelink.csproj::TargetFramework=net7.0]
    /vmr/dotnet/src/sourcelink/artifacts/source-build/self/src/src/dotnet-sourcelink/Program.cs(91,38): error CS7069: Reference to type 'ICommandHandler' claims it is defined in 'System.CommandLine', but it could not be found [/vmr/dotnet/src/sourcelink/artifacts/source-build/self/src/src/dotnet-sourcelink/dotnet-sourcelink.csproj::TargetFramework=net7.0]
    /vmr/dotnet/src/sourcelink/artifacts/source-build/self/src/src/dotnet-sourcelink/Program.cs(97,33): error CS7069: Reference to type 'ICommandHandler' claims it is defined in 'System.CommandLine', but it could not be found [/vmr/dotnet/src/sourcelink/artifacts/source-build/self/src/src/dotnet-sourcelink/dotnet-sourcelink.csproj::TargetFramework=net7.0]

Any idea what could be going on there?

[ViktorHofer]

@tmat I'm not seeing that ICommandHandler has changed recently but we're getting

The problem is that the system.commandline.namingconventionbinder dependency is lower than the others:

We are using an old build of namingconventionbinder.dll which expects the ICommandHandler type to be found somewhere else. That looks to be a source build authoring issue as the namingconventionbinder dependency is missing from the previously source built packages list:

[dsplaisted]

We are using an old build of namingconventionbinder.dll which expects the ICommandHandler type to be found somewhere else. That looks to be a source build authoring issue as the namingconventionbinder dependency is missing from the previously source built packages list:

Who's on point to fix this? Maybe @MichaelSimons?

[MichaelSimons]

Who's on point to fix this? Maybe @MichaelSimons?

Per a discussion in tactics, we made the decision to disable the source-build build leg in PRs to unblock the dependency flow PRs.