Skip to content

Conversation

@wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Jan 10, 2023

No description provided.

@wtgodbe wtgodbe requested review from dougbu and marcpopMSFT January 10, 2023 22:11
@wtgodbe
Copy link
Member Author

wtgodbe commented Jan 12, 2023

@dsplaisted @marcpopMSFT Microsoft.NET.Publish.Tests.GivenThatWeWantToPublishAHelloWorldProject.It_publishes_self_contained_apps_to_the_publish_folder_and_the_app_should_run is consistently failing on mac, could you take a look?

@marcpopMSFT
Copy link
Member

Per the test output, it's failing when trying to parse the tfm in nuget. I've pinged the nuget team but this is very odd. I have a change to disable that check in sdk repo that we can potentially explore: dotnet/sdk#29916

@wtgodbe
Copy link
Member Author

wtgodbe commented Jan 12, 2023

Per the test output, it's failing when trying to parse the tfm in nuget. I've pinged the nuget team but this is very odd. I have a change to disable that check in sdk repo that we can potentially explore: dotnet/sdk#29916

Do you recommend adding that workaround here? I'd like to get these in before tomorrow so we can hit the deadline

@marcpopMSFT
Copy link
Member

I think we just merge on red until we either know the issue or can prove the workaround I sent out will work.

@marcpopMSFT marcpopMSFT merged commit f379ff0 into release/7.0.1xx Jan 12, 2023
@marcpopMSFT marcpopMSFT deleted the wtgodbe/70111023 branch January 12, 2023 21:29
@dsplaisted
Copy link
Member

This may be fixed by dotnet/sdk#29083, which I just merged.

We can skip individual tests too. I tried to do that here but by the time I tried to commit the PR was already merged. I added the following to SdkTests.csproj:

    <PropertyGroup Condition=" $([MSBuild]::IsOSPlatform('OSX'))">
      <!-- Add list of tests to skip on x86 -->
      <TestArgs>$(TestArgs) -testConfigFile "$(MSBuildThisFileDirectory)TestsToSkipOSX.xml"</TestArgs>
    </PropertyGroup>

And created the following TestsToSkipOSX.xml file:

<Tests>
  <SkippedTests>
    <Method Name="Microsoft.NET.Publish.Tests.GivenThatWeWantToPublishAHelloWorldProject.It_publishes_self_contained_apps_to_the_publish_folder_and_the_app_should_run"
            Skip="true"
            Reason="Failure in SupportsTargetFramework, possibly fixed by https://github.com/dotnet/sdk/pull/29083"/>

  </SkippedTests>
</Tests>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants