Skip to content

Migrate four tools to commandline v2 #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jakobbotsch merged 23 commits into from
Jan 11, 2023
Merged

Migrate four tools to commandline v2 #362

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
8c9f7bf
Use System.CommandLine v2 in cijobs
am11 Oct 29, 2022
c83640e
Use System.CommandLine v2 in jit-analyze
am11 Oct 29, 2022
817444b
Use System.CommandLine v2 in jit-dasm-pmi
am11 Oct 30, 2022
f93be71
Use System.CommandLine v2 in jit-dasm
am11 Oct 30, 2022
66b27ce
Update configs
am11 Nov 9, 2022
32c3deb
Fix custom parsing and defaults
am11 Nov 9, 2022
1b61f17
Import common props in mutate-test
am11 Nov 9, 2022
2b316e9
Nitpicks
am11 Nov 9, 2022
1c52e3b
Merge dotnet/main into feature/command-line-api-v2
am11 Nov 18, 2022
bf68548
Bump version: 2.0.0-beta4.22564.1
am11 Nov 21, 2022
95056b2
Publish tools as single-file
am11 Nov 24, 2022
6e01009
Skip pmi projects and fix shell-check warnings
am11 Nov 25, 2022
4a347ba
Fix an error message
am11 Nov 25, 2022
eb01579
Align version option in System.CommandLine usages
am11 Dec 1, 2022
9840926
Only exclude PMI project from singlefile publishing
am11 Dec 11, 2022
5920112
Flip condition
am11 Dec 11, 2022
a9b0dd1
Updat comments
am11 Dec 11, 2022
08eb48d
Revert src/pmi/pmi.cs
am11 Jan 3, 2023
e4a8166
Make AssemblyList an argument to the command to preserve existing beh…
jakobbotsch Jan 10, 2023
b163b08
Fix some formatting
jakobbotsch Jan 10, 2023
7efb530
Fix NullReferenceException when not supplying any args to jit-dasm
jakobbotsch Jan 10, 2023
e9443b0
Also fix jit-dasm-pmi
jakobbotsch Jan 10, 2023
a51a231
Fix a typo
am11 Jan 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix NullReferenceException when not supplying any args to jit-dasm
  • Loading branch information
@jakobbotsch
jakobbotsch committed Jan 10, 2023
commit 7efb5309bbd9b60a9b2cc54080cf3d7e7ea4bfd0
18 changes: 10 additions & 8 deletions src/jit-dasm/JitDasmRootCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,15 +73,17 @@ public JitDasmRootCommand(string[] args) : base("Managed codegen diff tool (cros
{
errors.Add("Can't find --crossgen tool.");
}

string crossgenFilename = Path.GetFileNameWithoutExtension(crossgen).ToLower();
if (crossgenFilename == "crossgen")
{
CodeGeneratorV1 = true;
}
else if (crossgenFilename != "crossgen2")
else
{
errors.Add("--crossgen tool should be crossgen or crossgen2.");
string crossgenFilename = Path.GetFileNameWithoutExtension(crossgen).ToLower();
if (crossgenFilename == "crossgen")
{
CodeGeneratorV1 = true;
}
else if (crossgenFilename != "crossgen2")
{
errors.Add("--crossgen tool should be crossgen or crossgen2.");
}
}

if (Result.FindResultFor(Filename) == null && Result.GetValue(AssemblyList).Count == 0)
Expand Down