Backport #2362 (#2375)

Backports the file-based testing to release/6.0.2xx

Author: agocke

test/ILLink.RoslynAnalyzer.Tests/Interop/InternalCalls/ComTests.cs

@@ -0,0 +1,41 @@
+
+using System.Threading.Tasks;
+using Xunit;
+
+namespace ILLink.RoslynAnalyzer.Tests.Interop.InternalCalls
+{
+	public sealed class ComTests : LinkerTestBase
+	{
+		protected override string TestSuiteName => "Interop/InternalCalls/Com";
+
+		[Fact]
+		public Task DefaultConstructorOfParameterIsRemoved ()
+		{
+			return RunTest ();
+		}
+
+		[Fact]
+		public Task DefaultConstructorOfReturnTypeIsRemoved ()
+		{
+			return RunTest ();
+		}
+
+		[Fact]
+		public Task FieldsOfParameterAreRemoved ()
+		{
+			return RunTest ();
+		}
+
+		[Fact]
+		public Task FieldsOfReturnTypeAreRemoved ()
+		{
+			return RunTest ();
+		}
+
+		[Fact]
+		public Task FieldsOfThisAreRemoved ()
+		{
+			return RunTest ();
+		}
+	}
+}

test/ILLink.RoslynAnalyzer.Tests/Interop/InternalCalls/InternalCallsTests.cs

@@ -0,0 +1,47 @@
+
+using System.Threading.Tasks;
+using Xunit;
+
+namespace ILLink.RoslynAnalyzer.Tests.Interop
+{
+	public sealed class InternalCallsTests : LinkerTestBase
+	{
+		protected override string TestSuiteName => "Interop/InternalCalls";
+
+		[Fact]
+		public Task UnusedDefaultConstructorIsRemoved ()
+		{
+			return RunTest ();
+		}
+
+		[Fact]
+		public Task UnusedFieldsOfTypesAreNotRemoved ()
+		{
+			return RunTest ();
+		}
+
+		[Fact]
+		public Task UnusedFieldsOfTypesWhenHasThisAreNotRemoved ()
+		{
+			return RunTest ();
+		}
+
+		[Fact]
+		public Task DefaultConstructorOfReturnTypeIsNotRemoved ()
+		{
+			return RunTest ();
+		}
+
+		[Fact]
+		public Task UnusedDefaultConstructorOfTypePassedByRefIsNotRemoved ()
+		{
+			return RunTest ();
+		}
+
+		[Fact]
+		public Task UnusedFieldsOfTypesPassedByRefAreNotRemoved ()
+		{
+			return RunTest ();
+		}
+	}
+}

test/ILLink.RoslynAnalyzer.Tests/Interop/PInvoke/ComTests.cs

@@ -0,0 +1,41 @@
+
+using System.Threading.Tasks;
+using Xunit;
+
+namespace ILLink.RoslynAnalyzer.Tests.Interop.PInvoke
+{
+	public sealed class ComTests : LinkerTestBase
+	{
+		protected override string TestSuiteName => "Interop/PInvoke/Com";
+
+		[Fact]
+		public Task DefaultConstructorOfParameterIsRemoved ()
+		{
+			return RunTest ();
+		}
+
+		[Fact]
+		public Task DefaultConstructorOfReturnTypeIsRemoved ()
+		{
+			return RunTest ();
+		}
+
+		[Fact]
+		public Task FieldsOfParameterAreRemoved ()
+		{
+			return RunTest ();
+		}
+
+		[Fact]
+		public Task FieldsOfReturnTypeAreRemoved ()
+		{
+			return RunTest ();
+		}
+
+		[Fact]
+		public Task FieldsOfThisAreRemoved ()
+		{
+			return RunTest ();
+		}
+	}
+}

test/ILLink.RoslynAnalyzer.Tests/Interop/PInvoke/IndividualTests.cs

@@ -0,0 +1,17 @@
+
+using System.Threading.Tasks;
+using Xunit;
+
+namespace ILLink.RoslynAnalyzer.Tests.Interop.PInvoke
+{
+	public class IndividualTests : LinkerTestBase
+	{
+		protected override string TestSuiteName => "Interop/PInvoke/Individual";
+
+		[Fact]
+		public Task CanOutputPInvokes ()
+		{
+			return RunTest ();
+		}
+	}
+}

test/ILLink.RoslynAnalyzer.Tests/Interop/PInvoke/PInvokeTests.cs

@@ -0,0 +1,48 @@
+
+using System.Threading.Tasks;
+using Xunit;
+
+namespace ILLink.RoslynAnalyzer.Tests.Interop
+{
+	public sealed class PInvokeTests : LinkerTestBase
+	{
+		protected override string TestSuiteName => "Interop/PInvoke";
+
+
+		[Fact]
+		public Task UnusedDefaultConstructorIsRemoved ()
+		{
+			return RunTest ();
+		}
+
+		[Fact]
+		public Task UnusedFieldsOfTypesPassedByRefAreNotRemoved ()
+		{
+			return RunTest ();
+		}
+
+		[Fact]
+		public Task DefaultConstructorOfReturnTypeIsNotRemoved ()
+		{
+			return RunTest ();
+		}
+
+		[Fact]
+		public Task UnusedDefaultConstructorOfTypePassedByRefIsNotRemoved ()
+		{
+			return RunTest ();
+		}
+
+		[Fact]
+		public Task UnusedFieldsOfTypesAreNotRemoved ()
+		{
+			return RunTest ();
+		}
+
+		[Fact]
+		public Task UnusedPInvoke ()
+		{
+			return RunTest ();
+		}
+	}
+}

test/ILLink.RoslynAnalyzer.Tests/Interop/PInvoke/Warnings.cs

@@ -0,0 +1,17 @@
+
+using System.Threading.Tasks;
+using Xunit;
+
+namespace ILLink.RoslynAnalyzer.Tests.Interop.PInvoke
+{
+	public sealed class WarningsTests : LinkerTestBase
+	{
+		protected override string TestSuiteName => "Interop/PInvoke/Warnings";
+
+		[Fact]
+		public Task ComPInvokeWarning ()
+		{
+			return RunTest ();
+		}
+	}
+}

test/ILLink.RoslynAnalyzer.Tests/LinkerTestBase.cs

@@ -0,0 +1,20 @@
+
+using System.Runtime.CompilerServices;
+using System.Threading.Tasks;
+
+namespace ILLink.RoslynAnalyzer.Tests
+{
+	public abstract class LinkerTestBase : TestCaseUtils
+	{
+		protected abstract string TestSuiteName { get; }
+
+		private static readonly (string, string)[] MSBuildProperties = UseMSBuildProperties (
+			MSBuildPropertyOptionNames.EnableTrimAnalyzer,
+			MSBuildPropertyOptionNames.EnableSingleFileAnalyzer);
+
+		protected Task RunTest ([CallerMemberName] string testName = "")
+		{
+			return RunTestFile (TestSuiteName, testName, MSBuildProperties);
+		}
+	}
+}

test/ILLink.RoslynAnalyzer.Tests/LinkerTestCases.cs

@@ -0,0 +1,41 @@
+
+using System.Threading.Tasks;
+using Xunit;
+
+namespace ILLink.RoslynAnalyzer.Tests
+{
+	public sealed class RequiresCapabilityTests : LinkerTestBase
+	{
+		protected override string TestSuiteName => "RequiresCapability";
+
+		[Fact]
+		public Task RequiresCapability ()
+		{
+			return RunTest (nameof (RequiresCapability));
+		}
+
+		[Fact]
+		public Task RequiresCapabilityFromCopiedAssembly ()
+		{
+			return RunTest (nameof (RequiresCapabilityFromCopiedAssembly));
+		}
+
+		[Fact]
+		public Task RequiresCapabilityReflectionAnalysisEnabled ()
+		{
+			return RunTest (nameof (RequiresCapabilityReflectionAnalysisEnabled));
+		}
+
+		[Fact]
+		public Task RequiresInCompilerGeneratedCode ()
+		{
+			return RunTest (nameof (RequiresInCompilerGeneratedCode));
+		}
+
+		[Fact]
+		public Task RequiresOnAttributeCtor ()
+		{
+			return RunTest (nameof (RequiresOnAttributeCtor));
+		}
+	}
+}

test/ILLink.RoslynAnalyzer.Tests/RequiresCapabilityTests.cs

@@ -28,34 +28,28 @@ public TestCase (MemberDeclarationSyntax memberSyntax, IEnumerable<AttributeSynt
 			Attributes = attributes;
 		}
 
-		public void Run (params (string, string)[] MSBuildProperties)
+		public void Run ((CompilationWithAnalyzers, SemanticModel) compAndModel)
 		{
-			var testSyntaxTree = MemberSyntax.SyntaxTree.GetRoot ().SyntaxTree;
+			var testSyntaxTree = MemberSyntax.SyntaxTree;
 			var testDependenciesSource = GetTestDependencies (testSyntaxTree)
 				.Select (testDependency => CSharpSyntaxTree.ParseText (File.ReadAllText (testDependency)));
 
-			var test = new TestChecker (
-				MemberSyntax,
-				TestCaseCompilation.CreateCompilation (
-					testSyntaxTree,
-					MSBuildProperties,
-					additionalSources: testDependenciesSource).Result);
-
+			var test = new TestChecker (MemberSyntax, compAndModel);
 			test.ValidateAttributes (Attributes);
 		}
 
-		private static IEnumerable<string> GetTestDependencies (SyntaxTree testSyntaxTree)
+		public static IEnumerable<string> GetTestDependencies (SyntaxTree testSyntaxTree)
 		{
-			TestCaseUtils.GetDirectoryPaths (out var rootSourceDir, out _);
+			LinkerTestBase.GetDirectoryPaths (out var rootSourceDir, out _);
 			foreach (var attribute in testSyntaxTree.GetRoot ().DescendantNodes ().OfType<AttributeSyntax> ()) {
 				if (attribute.Name.ToString () != "SetupCompileBefore")
 					continue;
 
 				var testNamespace = testSyntaxTree.GetRoot ().DescendantNodes ().OfType<NamespaceDeclarationSyntax> ().Single ().Name.ToString ();
 				var testSuiteName = testNamespace.Substring (testNamespace.LastIndexOf ('.') + 1);
-				var args = TestCaseUtils.GetAttributeArguments (attribute);
+				var args = LinkerTestBase.GetAttributeArguments (attribute);
 				foreach (var sourceFile in ((ImplicitArrayCreationExpressionSyntax) args["#1"]).DescendantNodes ().OfType<LiteralExpressionSyntax> ())
-					yield return Path.Combine (rootSourceDir, testSuiteName, TestCaseUtils.GetStringFromExpression (sourceFile));
+					yield return Path.Combine (rootSourceDir, testSuiteName, LinkerTestBase.GetStringFromExpression (sourceFile));
 			}
 		}
 	}