Move analyzer tests to one test per file #2362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves away from generating Theory cases for each method in the file and uses one Fact per test file.
sbomer
reviewed
Nov 12, 2021
|
|
||
| [Theory] | ||
| [MemberData (nameof (TestCaseUtils.GetTestData), parameters: nameof (Interop))] | ||
| public void Interop (string m) |
Member
There was a problem hiding this comment.
I don't think we want to remove the interop tests, do we? Also these are an exception to normal directory structure - the testcases are defined in nested directories so we should make sure that still works.
vitek-karas
approved these changes
Nov 12, 2021
Member
vitek-karas
left a comment
vitek-karas
left a comment
There was a problem hiding this comment.
The Interop tests should be kept. Otherwise looks good.
agocke
added a commit
to agocke/linker
that referenced
this pull request
Nov 16, 2021
Backports the file-based testing to release/6.0.2xx
agocke
added a commit
to dotnet/runtime
that referenced
this pull request
Nov 16, 2022
Move analyzer tests to one test per file Commit migrated from dotnet/linker@f2dd65f
agocke
added a commit
to dotnet/runtime
that referenced
this pull request
Nov 16, 2022
Backports the file-based testing to release/6.0.2xx Commit migrated from dotnet/linker@8e8c6c7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves away from generating Theory cases for each method in the file and
uses one Fact per test file.