Where the access calls a getter or setter defined on a base class.

…613.1 (#2834)

[main] Update dependencies from dotnet/arcade

…0612.5 (#2835)

[main] Update dependencies from dotnet/runtime

* Fix event assignment in analyzer

* Add field test to simulate EmptyTypes in runtime

* Add test for write to captured set-only property

* Add test for #2832

* Avoid visiting captured reference operation

Since we can't detect whether it is used for reading or writing.
Fixes assignment to captured set-only property and assignment to
Type.EmptyTypes.

* Cleanup

* PR feedback

- Add more detailed comment
- Add tests for property instance visiting

Previously we only marked the type forwarder for the outer-most type (if any), but the same problem can happen with type names in generic arguments. If they are forwarder we need to mark those type forwarders as well.

This change records all type resolutions during the string->Type resolution and then makes sure that all type forwarders used get marked.

Renamed a method on HandleCallAction to make it more descriptive of what it actually does. Also unifies all string->Type resolution into the ReflectionMarker.

Enabled test which has been already added for the bug and added another variation (CreateInstance).

Improved ResultsChecker to include assembly names in validation messages.

…tson dump (#2825)

Enables more precise removal of static abstract interface methods and adds more tests than previously.

Co-authored-by: Sven Boemer <[email protected]>

In general, a task invocation in MSBuild and the task definition are
inseparable. Adding parameters to the task will either result in errors
if the target is updated and too new, or silently skipping the parameter
if the target is too old.

Best practice is to ship both as a pair to prevent this problem. Testing is
harder, but we can add some limited testing if necessary to the linker repo.

Adds support for `IImplicitIndexerReferenceOperation`, which
represents an implicit access to an indexer that uses
`System.Index`. Implicit means that there is no `System.Index`
accessor in IL, but the compiler supports `System.Index` access
via an existing indexer (for example one that takes int) for
types that satisfy certain criteria. See
https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/proposals/csharp-8.0/ranges#implicit-index-support
for details.

This operation only showed up in the CFG with a more recent
version of the Roslyn APIs, so this includes an update to match
the one used in dotnet/runtime. This resulted in a few changes to
the generated code that required tweaking some of the test
validation:

- Delegate cache fields are emitted. This reuses an existing
attribute originally designed for mcs, but it has been updated to
check for these compiler-generated fields.

- `<PrivateImplementationDetails>.ThrowSwitchExpressionException`
is emitted for an implicit unhandled case in switch
expressions. This change includes a new attribute to check that
this is kept in a few of the tests.

…2841)

This reverts commit ff646e0.

This is a workaround and test for #2845

…0619.5 (#2851)

[main] Update dependencies from dotnet/runtime

…616.2 (#2850)

[main] Update dependencies from dotnet/arcade

This should keep the existing package override logic working, since
the current SDK will only import the in-box ILLink.Tasks.props if
this is not already set.

After updating to SDK Preview 5, there are new warnings about being able to seal classes that breaks the build (CA1852). This PR adds the sealed modifier to classes to silence the warnings.