Mark all type forwarders used during string->Type resolution #2836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we only marked the type forwarder for the outer-most type (if any), but the same problem can happen with type names in generic arguments. If they are forwarder we need to mark those type forwarders as well. This change records all type resolutions during the string->Type resolution and then makes sure that all type forwarders used get marked. Renamed a method on HandleCallAction to make it more descriptive of what it actually does. Also unifies all string->Type resolution into the ReflectionMarker. Enabled test which has been already added for the bug and added another variation (CreateInstance). Improved ResultsChecker to include assembly names in validation messages.
agocke
pushed a commit
to dotnet/runtime
that referenced
this pull request
Nov 16, 2022
…linker#2836) Previously we only marked the type forwarder for the outer-most type (if any), but the same problem can happen with type names in generic arguments. If they are forwarder we need to mark those type forwarders as well. This change records all type resolutions during the string->Type resolution and then makes sure that all type forwarders used get marked. Renamed a method on HandleCallAction to make it more descriptive of what it actually does. Also unifies all string->Type resolution into the ReflectionMarker. Enabled test which has been already added for the bug and added another variation (CreateInstance). Improved ResultsChecker to include assembly names in validation messages. Commit migrated from dotnet/linker@27b9dd6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we only marked the type forwarder for the outer-most type (if any), but the same problem can happen with type names in generic arguments. If they are forwarder we need to mark those type forwarders as well.
This change records all type resolutions during the string->Type resolution and then makes sure that all type forwarders used get marked.
Renamed a method on HandleCallAction to make it more descriptive of what it actually does. Also unifies all string->Type resolution into the ReflectionMarker.
Enabled test which has been already added for the bug and added another variation (CreateInstance).
Improved ResultsChecker to include assembly names in validation messages.
Fixes #1536