Skip to content

Warn when accessing DAM annotated method via reflection #2145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbomer merged 6 commits into from
Jul 29, 2021
Merged

Warn when accessing DAM annotated method via reflection #2145

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
dee0419
Warn when accessing DAM annotated method via reflection
vitek-karas Jun 23, 2021
4ddd3ed
Formatting
vitek-karas Jul 14, 2021
e640a9e
Only warn on virtual methods with annotate return value
vitek-karas Jul 15, 2021
ac215d3
PR feedback
vitek-karas Jul 22, 2021
5d180d5
PR feedback
vitek-karas Jul 26, 2021
23a62ac
Remove test code.
vitek-karas Jul 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove test code.
  • Loading branch information
@vitek-karas
vitek-karas committed Jul 26, 2021
commit 23a62ac924475132a3b185c4d0f93c016f0e437e
4 changes: 0 additions & 4 deletions src/linker/Linker.Steps/MarkStep.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2871,10 +2871,6 @@ void ProcessAnalysisAnnotationsForMethod (MethodDefinition method, DependencyKin
}
}

Type _typeField;

private ref Type GetRefType () { Type type = null; return ref _typeField; }

internal bool ShouldSuppressAnalysisWarningsForRequiresUnreferencedCode ()
{
// Check if the current scope method has RequiresUnreferencedCode on it
Expand Down