Fix handling of unknown BindingFlags #2288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
` GetDynamicallyAccessedMemberTypesFromBindingFlagsForXXX` would return `DynamicallyAccessedMembers.None` when the binding flags are null/unknown. This fix is a bit more targeted so that we can potentially take it to 6.0. In general, there's some duality in how BindingFlags are handled - there are places that call `BindingFlagsAreUnsupported` and avoid `GetDynamicallyAccessedMemberTypesFromBindingFlagsForXXX` for null that way. Others call into this API without checking whether the flags are supported first. I'm unclear whether it would be more appropriate to check for `BindingFlagsAreUnsupported` in the code I'm adding. It's a valid option as well.
vitek-karas
approved these changes
Sep 21, 2021
MichalStrehovsky
changed the title
agocke
added a commit
to agocke/linker
that referenced
this pull request
Oct 28, 2021
This reverts commit 02b53c5.
agocke
pushed a commit
to dotnet/runtime
that referenced
this pull request
Nov 16, 2022
` GetDynamicallyAccessedMemberTypesFromBindingFlagsForXXX` would return `DynamicallyAccessedMembers.None` when the binding flags are null/unknown. This fix is a bit more targeted so that we can potentially take it to 6.0. In general, there's some duality in how BindingFlags are handled - there are places that call `BindingFlagsAreUnsupported` and avoid `GetDynamicallyAccessedMemberTypesFromBindingFlagsForXXX` for null that way. Others call into this API without checking whether the flags are supported first. I'm unclear whether it would be more appropriate to check for `BindingFlagsAreUnsupported` in the code I'm adding. It's a valid option as well. Commit migrated from dotnet/linker@108fe5b
agocke
added a commit
to dotnet/runtime
that referenced
this pull request
Nov 16, 2022
This reverts commit dotnet/linker@108fe5b. Commit migrated from dotnet/linker@02b53c5
agocke
added a commit
to dotnet/runtime
that referenced
this pull request
Nov 16, 2022
)"" This reverts commit dotnet/linker@02b53c5. Commit migrated from dotnet/linker@aba0e20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found on the NativeAOT side, since we're bug-for-bug compatible.
GetDynamicallyAccessedMemberTypesFromBindingFlagsForXXXwould returnDynamicallyAccessedMembers.Nonewhen the binding flags are null/unknown.This fix is a bit more targeted so that we can potentially take it to 6.0.
In the existing linker code, there's some duality in how BindingFlags are handled - there are places that call
BindingFlagsAreUnsupportedand avoidGetDynamicallyAccessedMemberTypesFromBindingFlagsForXXXfor null that way. Others call into this API without checking whether the flags are supported first.I'm unclear whether it would be more appropriate to check for
BindingFlagsAreUnsupportedin the code I'm adding. It's a valid option as well.