Adds a test for multiple nested forwarders in a row with copy/link #2372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problematic scenario is if there's a "copy" assembly with a forwarder to a "link" assembly with a forwarder. The forwarder is for a nested class. Test for dotnet#2359. Also improved the test infra to print out errors from ilasm if they happen.
marek-safar
approved these changes
Nov 16, 2021
vitek-karas
added a commit
to vitek-karas/linker
that referenced
this pull request
Nov 22, 2021
…otnet#2372) The problematic scenario is if there's a "copy" assembly with a forwarder to a "link" assembly with a forwarder. The forwarder is for a nested class. Test for dotnet#2359. Also improved the test infra to print out errors from ilasm if they happen.
agocke
pushed a commit
to dotnet/runtime
that referenced
this pull request
Nov 16, 2022
…otnet/linker#2372) The problematic scenario is if there's a "copy" assembly with a forwarder to a "link" assembly with a forwarder. The forwarder is for a nested class. Test for dotnet/linker#2359. Also improved the test infra to print out errors from ilasm if they happen. Commit migrated from dotnet/linker@57574f1
agocke
pushed a commit
to dotnet/runtime
that referenced
this pull request
Nov 16, 2022
…otnet/linker#2372) The problematic scenario is if there's a "copy" assembly with a forwarder to a "link" assembly with a forwarder. The forwarder is for a nested class. Test for dotnet/linker#2359. Also improved the test infra to print out errors from ilasm if they happen. Commit migrated from dotnet/linker@70cd7ed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problematic scenario is if there's a "copy" assembly with a forwarder to a "link" assembly with a forwarder. The forwarder is for a nested class.
Test for #2359.
The reason for "Random" behavior is a Cecil issue: jbevain/cecil#812.
Also improved the test infra to print out errors from ilasm if they happen.