-
Notifications
You must be signed in to change notification settings - Fork 128
Re-add static interface trimming with more testing #2791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
f704291
Re-add static interface trimming with more testing
jtschuster 68c530d
Add static interface tests for library mode
jtschuster 97cd617
Add sanity check for overrides
jtschuster 8190bf7
Add sanity check for overrides
jtschuster 9a5fe0f
Merge branch 'main' into overrideSanityCheck
jtschuster 3a560d4
Merge branch 'overrideSanityCheck' into staticInterfacesBack
jtschuster 733bf90
Update comment on override removal in sweep step
jtschuster 47104d9
Add attributes
jtschuster c2f4fd1
formatting
jtschuster 3d577ce
formatting
jtschuster 8ac16bb
Merge branch 'overrideSanityCheck' into staticInterfacesBack
jtschuster cccca4c
Modify override removal logic and update comment
jtschuster c380027
Mark override on explicit implementation
jtschuster 4813047
Tweak override removal comment
jtschuster 332e79f
wip
jtschuster 9f64a32
Merge branch 'main' into staticInterfacesBack
jtschuster 9d27c3b
Merge remote-tracking branch 'upstream/main' into staticInterfacesBack
jtschuster 7f1064d
Choose correct merge conflict
jtschuster 15db395
use FullName in comparison
jtschuster 1751697
wip
jtschuster b10cd5f
Update docs/removal-behavior.md
jtschuster e3fbf12
Add explanation for workaround to remove interface implementation
jtschuster 098cb24
Merge branch 'staticInterfacesBack' of https://github.com/jtschuster/…
jtschuster 7467d82
wip
jtschuster 4efa5f2
Mark static interface implmentations in ProcessOverride
jtschuster c3a26ca
Format and update comment
jtschuster 62e3cc8
Use separate list for static interface methods
jtschuster 4359792
Add clarifying comments
jtschuster 060345e
Roll early exit case into function
jtschuster a050fdf
Move check back outside of interface override method
jtschuster 95df541
formatting
jtschuster 2b7a7cc
Use Override pair to store logic for IsStaticInterfaceMethodPair
jtschuster c00e1d1
Formatting
jtschuster 358b010
Move interfaceImpl marking out of ProcessOverride
jtschuster 5672f0f
Merge remote-tracking branch 'upstream/main' into staticInterfacesBack
jtschuster 432375d
PR Feedback
jtschuster File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Tweak override removal comment
- Loading branch information
commit 48130478cc973db6a17ccd36462d67a5cb737a6f
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.