Changes to make sharing code with Native AOT easier #2818
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbomer
approved these changes
Jun 3, 2022
agocke
pushed a commit
to dotnet/runtime
that referenced
this pull request
Nov 16, 2022
* Change FlowAnnotations to a ref type (class) - in AOT and linker it stores non-trivial amount of state (caches) and thus should be shared (ideally single instance). Struct is not very practical for such usage. * Explicitly mark all sources in the shared project as `#nullable enable` since Native AOT doesn't enable nullable project wide yet. * Add several new intrinsics which are specific to AOT - considered separating these out, but it's probably not worth it. It's likely the analyzer should eventually react to these as well, so linker will be the only one not using them. * Added one more test for an interesting case of RUC suppressing warnings in attribute processing. Commit migrated from dotnet/linker@94cc93c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#nullable enablesince Native AOT doesn't enable nullable project wide yet.