Revert "Revert "Re-add static interface trimming with more testing"" #2859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbomer
reviewed
Jun 24, 2022
Member
sbomer
left a comment
sbomer
left a comment
There was a problem hiding this comment.
This is just a revert of 4bed0da, right? Please force push so that the commits in this PR are just a single revert commit, with any extra changes in separate commits on top of that. This will make it easier to review just the changes if there are any.
…otnet#2791)" (dotnet#2841)" This reverts commit 4bed0da.
jtschuster
force-pushed
the
rereaddstaticinterfaces
branch
from
0448fb7 to
3a618bb
Compare
Member
Author
|
Now that static virtual interface methods are possible, more tests need to be written before this gets reviewed and merged. |
Member
Author
|
#2868 encompasses these changes |
jtschuster
added a commit
that referenced
this pull request
Aug 3, 2022
…ace methods (#2868) Fixes #2865 Also addresses marking of all static interface methods encompassing the changes from #2859, and updates the way that all interface methods are marked. Whether or not we mark an interface method due to its base method is now separated from marking other virtual methods and the marking is postponed to ProcessMarkedTypesWithInterface. In ProcessMarkedTypesWithInterfaces, interface implementations are marked, and methods that implement a marked/implemented interface are marked. Tests for static interface methods have also been updated. Co-authored-by: Sven Boemer <[email protected]>
agocke
pushed a commit
to dotnet/runtime
that referenced
this pull request
Nov 16, 2022
…ace methods (dotnet/linker#2868) Fixes dotnet/linker#2865 Also addresses marking of all static interface methods encompassing the changes from dotnet/linker#2859, and updates the way that all interface methods are marked. Whether or not we mark an interface method due to its base method is now separated from marking other virtual methods and the marking is postponed to ProcessMarkedTypesWithInterface. In ProcessMarkedTypesWithInterfaces, interface implementations are marked, and methods that implement a marked/implemented interface are marked. Tests for static interface methods have also been updated. Co-authored-by: Sven Boemer <[email protected]> Commit migrated from dotnet/linker@118bdca
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The failures that led to reverting static interface trimming (https://github.com/dotnet/runtime/runs/6900652466 -
System.Security.Cryptography.CngKey'sIDisposableinterface implementation was trimmed) seem to be related to the build using the wrong version of the linker (#2848). When using the linker directly with these changes, I haven't been able to repro the issue. This PR reverts the revert and adds the static interface trimming capability back.