Skip to content

Conversation

@sbomer
Copy link
Member

@sbomer sbomer commented Aug 25, 2022

Backport of #3003
Fixes #2982

…#3003)

This replaces
dotnet@82c6dc6
with a different approach. Now SuppressTrimAnalysisWarnings only
suppresses those warnings defined to be part of the "trim analysis"
category, using a separate command-line argument.  An exception is 5.0
apps, where the setting continues to suppress specific warnings for
compatibility.
@sbomer sbomer marked this pull request as ready for review August 25, 2022 22:51
@sbomer sbomer requested a review from marek-safar as a code owner August 25, 2022 22:51
@sbomer sbomer requested a review from jeffschwMSFT August 25, 2022 23:18
Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved.

@sbomer sbomer merged commit abb08f9 into dotnet:release/7.0 Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants