Skip to content

Add license and SourceBuild.props to satisfy post-build checks #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
crummel wants to merge 3 commits into from
Closed

Add license and SourceBuild.props to satisfy post-build checks #242

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b57db5a
Copy license form LLVM directory to root directory to satisfy license…
crummel Aug 11, 2022
b73784e
Add SourceBuild.props.
crummel Aug 11, 2022
62ac465
Address code review comment.
crummel Feb 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions eng/SourceBuild.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
<Project>

<PropertyGroup>
<GitHubRepositoryName>llvm-project</GitHubRepositoryName>
<SourceBuildManagedOnly>true</SourceBuildManagedOnly>
<PackageLicenseFile>$(RepoRoot)/llvm/LICENSE.TXT</PackageLicenseFile>
Copy link
Member

@akoeplinger akoeplinger Feb 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we're already setting this here:

llvm-project/nuget/packaging.props

Line 6 in 7de031a

<PackageLicenseFile>$(RepoRoot)/llvm/LICENSE.TXT</PackageLicenseFile>

I wonder why that isn't working in the SourceBuild case?

I'm fine with checking this in if it unblocks you though.

Copy link
Author

@crummel crummel Feb 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'll write up an issue to look into this further but that would be good.

Copy link
Member

@akoeplinger akoeplinger Feb 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I didn't see that this was targetting the objwriter/12.x branch which is owned by the JIT team. We've recently merged the objwriter changes into main so for .NET8 there should only be one branch: #287

Do you need it in earlier branches or can this be retargeted to main?

</PropertyGroup>

</Project>