Skip to content

Conversation

@agocke
Copy link
Member

@agocke agocke commented Feb 4, 2023

The runtime CI needs llvm-dwarfdump for NativeAOT, so add it to the Mono Tools package. Right now there doesn't seem to be a good reason to create a new package.

@akoeplinger
Copy link
Member

#287 is adding a Microsoft.NETCore.Runtime.JIT.Tools package, it'd fit better there. Should we wait until that PR is merged?

@agocke
Copy link
Member Author

agocke commented Feb 4, 2023

Didn't see that at all, yeah that sounds great, we'll wait for that.

@MichalStrehovsky
Copy link
Member

Didn't see that at all, yeah that sounds great, we'll wait for that.

The JIT team is also already publishing this package from the objwriter branch (#256). The tool that is in that package (llvm-mca) is already used in the src/tests tree of the runtime repo, so it's exactly what we'd want.

@agocke agocke force-pushed the add-llvm-dwarfdump branch from 0cf1064 to f4e2209 Compare February 7, 2023 19:02
@agocke
Copy link
Member Author

agocke commented Feb 7, 2023

This has been updated to add llvm-dwarfdump to the JIT tools package

Copy link
Member

@MichalStrehovsky MichalStrehovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but @BrianBohe @markples @TIHan should have a look as well - this tool is for objwriter testing after all.

@agocke
Copy link
Member Author

agocke commented Feb 9, 2023

Merging to unblock some testing. Happy to respond to any comments that come in later.

@agocke agocke merged commit 6dbdaa1 into dotnet:dotnet/main Feb 9, 2023
@agocke agocke deleted the add-llvm-dwarfdump branch February 9, 2023 18:52
@BrianBohe
Copy link
Member

Sorry for the late reply. I am okey with adding any tool you think would be necessary for testing or development. It shouldn't be a problem to build another piece of the same llvm platform

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants