Skip to content

Convert LdaTransform to IEstimator/ITransformer API #1410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shauheen merged 38 commits into from
Nov 20, 2018
Merged

Convert LdaTransform to IEstimator/ITransformer API #1410

Changes from 1 commit
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
acd8964
preparing to convert LDATransform to the IEstimator/ITransformer para…
abgoswam Oct 24, 2018
cd2f20c
Added ColumnInfo and TransformInfo
abgoswam Oct 24, 2018
c289ed1
existing tests pass after refactor
abgoswam Oct 25, 2018
8dfb527
fix re-arragement of arguments in entrypoints
abgoswam Oct 25, 2018
bcb3b0d
refactor + cleanup of TopicSummary
abgoswam Oct 25, 2018
1d39408
enabled OnFit to return LdaState
abgoswam Oct 27, 2018
9ff60f7
fixed merge conflicts
abgoswam Nov 1, 2018
ad36d2f
fix build issues after merge; fix review comments
abgoswam Nov 1, 2018
b0e0375
taking care of review comments - 1
abgoswam Nov 10, 2018
b0422e4
Merge branch 'master' into abgoswam/LDA_conversion
abgoswam Nov 10, 2018
7bc6e2b
merge with master; re-enable LDA tests before taking care of addition…
abgoswam Nov 10, 2018
e42c5e4
review comments - 2. rename LdaTransform to LdaTransformer
abgoswam Nov 10, 2018
c099d4a
review comments - 3. throw ExceptSchemaMismatch; default values; ToIm…
abgoswam Nov 11, 2018
a1d14ed
review comments - 4. output column; expression body definition
abgoswam Nov 12, 2018
3f39a04
review comments - 4; added a basic test that exercises TestEstimatorC…
abgoswam Nov 12, 2018
57cd1c5
review comments - 5; rename _exes to _columns; preparing changes for …
abgoswam Nov 12, 2018
d4a4283
review comments - 6; make training a private static method.
abgoswam Nov 12, 2018
c7fb50a
review comments - 7; make Create() method private
abgoswam Nov 12, 2018
d7660ca
review comments - 8; added internal constructor for ColumnInfo()
abgoswam Nov 12, 2018
e0d501b
review comments - 9; fixed types for Single, Float
abgoswam Nov 12, 2018
c91afbb
review comments - 10; made LdaState internal, expose LDA summary info…
abgoswam Nov 13, 2018
4238fa1
review comments - 11; added a command line unit test
abgoswam Nov 13, 2018
34bb2e9
review comments - 12; no-op when there is no data (maml command line …
abgoswam Nov 13, 2018
8b70ab1
review comments - 13; added mlcontext extension for LDA
abgoswam Nov 14, 2018
b3c1284
Merge branch 'master' into abgoswam/LDA_conversion
abgoswam Nov 14, 2018
b6e4028
review comments - 14; code refactor; avoid using abbreviation(Lda); r…
abgoswam Nov 15, 2018
5397de5
review comments - 15; schema changes
abgoswam Nov 15, 2018
edd60af
review comments - 15; provide better user-facing description. renamed…
abgoswam Nov 15, 2018
b073038
review comments - 16; fix build break
abgoswam Nov 15, 2018
49da3ee
review comments - 16; include words in LdaSummary (this also resolves…
abgoswam Nov 16, 2018
0724290
fixing merge conflicts
abgoswam Nov 16, 2018
5073baa
fixing merge conflicts
abgoswam Nov 17, 2018
d1481f8
fix build break because of manifest changes
abgoswam Nov 17, 2018
65125d4
Merge branch 'master' into abgoswam/LDA_conversion
abgoswam Nov 20, 2018
b869d7f
updated to latest interface changes
abgoswam Nov 20, 2018
62955a8
review comments - 17; named tuple, namespace change, fix CheckParams
abgoswam Nov 20, 2018
40333a7
review comments - 18; ImmutableArray
abgoswam Nov 20, 2018
850856b
review comments - 19; update summary text; remove dup code in constru…
abgoswam Nov 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor + cleanup of TopicSummary
  • Loading branch information
@abgoswam
abgoswam committed Oct 25, 2018
commit bcb3b0deb85d42c58dbb2afc7f6fdc6c7423ab9b
Loading