Adding the CommonPackage.props file to FastTree. #3628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The FastTree NuGet package is currently broken on .NET Framework when using packages.config because we are not copying the native files to the output folder. Fix dotnet#3626
eerhardt
requested review from
codemzs,
Ivanidzo4ka,
shauheen,
TomFinley and
glebuk
codemzs
approved these changes
Apr 30, 2019
Ivanidzo4ka
approved these changes
Apr 30, 2019
glebuk
approved these changes
Apr 30, 2019
Codecov Report
@@ Coverage Diff @@
## master #3628 +/- ##
==========================================
- Coverage 72.78% 72.78% -0.01%
==========================================
Files 808 808
Lines 145548 145548
Branches 16248 16248
==========================================
- Hits 105931 105930 -1
Misses 35195 35195
- Partials 4422 4423 +1
|
shauheen
approved these changes
Apr 30, 2019
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FastTree NuGet package is currently broken on .NET Framework when using packages.config because we are not copying the native files to the output folder.
Fix #3626