Skip to content

Conversation

yaeldekel
Copy link

When combining per-instance data views, key columns with text key values should be handled only once.
Fixes #435 .

@yaeldekel yaeldekel requested review from codemzs and shauheen June 27, 2018 18:14
Copy link
Contributor

@Ivanidzo4ka Ivanidzo4ka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Member

@sfilipi sfilipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@yaeldekel yaeldekel merged commit 9e0a4ba into dotnet:master Jun 27, 2018
@yaeldekel yaeldekel deleted the fixevalutils branch June 27, 2018 21:41
eerhardt pushed a commit to eerhardt/machinelearning that referenced this pull request Jul 27, 2018
* Fix bug dotnet#435.

* Fix unit tests.

* Fix bug in generating new key column.
@ghost ghost locked as resolved and limited conversation to collaborators Mar 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants