Skip to content

Conversation

@rolfbjarne
Copy link
Member

@rolfbjarne rolfbjarne requested a review from chamons as a code owner August 26, 2022 16:30
@rolfbjarne rolfbjarne added the not-notes-worthy Ignore for release notes label Aug 26, 2022
@rolfbjarne rolfbjarne added the needs-babysitting PR requires someone in another time zone to look after label Aug 26, 2022
@vs-mobiletools-engineering-service2

This comment has been minimized.

@dalexsoto
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vs-mobiletools-engineering-service2

This comment has been minimized.

@chamons chamons removed the needs-babysitting PR requires someone in another time zone to look after label Aug 26, 2022
@chamons
Copy link
Contributor

chamons commented Aug 26, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lambdageek
Copy link
Member

lambdageek commented Aug 26, 2022

I'm now a little bit concerned that this was the wrong fix.
When using the interpreter you link the mono-ilgen.a library and I think in that case the call to mono_marshal_ilgen_init has to stay. So maybe we need the runtime fix dotnet/runtime#74658 after all

https://github.com/xamarin/xamarin-macios/blob/028afc2eabb4af8b7087ebd7f9a6cf6f66ec96b8/tools/mtouch/Target.mtouch.cs#L1530

@chamons chamons added the do-not-merge Do not merge this pull request label Aug 26, 2022
@chamons
Copy link
Contributor

chamons commented Aug 26, 2022

Adding do-not-merge until runtime folks give us a final 👍 / 👎 on the fix - @lambdageek @steveisok

FYI @dalexsoto

@dalexsoto dalexsoto removed the do-not-merge Do not merge this pull request label Aug 26, 2022
@lambdageek
Copy link
Member

just to record our thinking. we think 👍 because it unblocks key scenarios (hot reload; other uses of the interpreter) but it is not 100% the correct fix because it seems like there are circumstances where mono_marshal_ilgen_inti does real work (I am not 100% clear on what scenario tht might be - something with the interpreter and maybe SRE calling a p/invoke).

We also started a PR to explore reverting the ilgen componentization (dotnet/runtime#74675).

@dalexsoto
Copy link
Member

As noted, the plan is to keep going on this PR and if dotnet/runtime#74675 makes the RC1 cut we will need to revert the ilgen component changes in both macios and android (/cc @jonathanpeppers ) once the RC1 runtime build flows to us.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🔥 Failed to compare API and create generator diff 🔥

Failed to update apidiff references

Pipeline on Agent
Hash: f67e77e54a1fd0be31654e28778d5774931dee01 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻

All tests on macOS Mac Catalina (10.15) passed.

Pipeline on Agent
Hash: f67e77e54a1fd0be31654e28778d5774931dee01 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1100.Monterey'
Hash: f67e77e54a1fd0be31654e28778d5774931dee01 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1109.Monterey
Hash: f67e77e54a1fd0be31654e28778d5774931dee01 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻

All tests on macOS Mac Catalina (10.15) passed.

Pipeline on Agent
Hash: f67e77e54a1fd0be31654e28778d5774931dee01 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🔥 Failed to compare API and create generator diff 🔥

Failed to update apidiff references

Pipeline on Agent
Hash: f67e77e54a1fd0be31654e28778d5774931dee01 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Failed tests are:

  • introspection
  • xammac_tests
  • monotouch-test

Pipeline on Agent
Hash: f67e77e54a1fd0be31654e28778d5774931dee01 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Failed tests are:

  • introspection
  • xammac_tests
  • monotouch-test

Pipeline on Agent
Hash: f67e77e54a1fd0be31654e28778d5774931dee01 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: simulator tests

0 tests crashed, 1 tests failed, 222 tests passed.

Failures

❌ monotouch tests

1 tests failed, 22 tests passed.
Details
  • monotouch-test/watchOS 32-bits - simulator/Release (all optimizations): TimedOut

Html Report (VSDrops) Download

Successes

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: simulator tests

0 tests crashed, 1 tests failed, 222 tests passed.

Failures

❌ mmp tests

1 tests failed, 1 tests passed.
Details
  • mmptest/macOS/Debug: Failed (Execution failed with exit code 2)

Html Report (VSDrops) Download

Successes

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 23 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: [PR build]

@rolfbjarne
Copy link
Member Author

Test failure are unrelated (https://github.com/xamarin/maccore/issues/2612).

@rolfbjarne
Copy link
Member Author

Merging this while waiting for the revert of the ilgen componentization (dotnet/runtime#74675) to flow to us.

@rolfbjarne rolfbjarne merged commit aa55ea9 into dotnet:release/7.0.1xx-rc1 Aug 29, 2022
@rolfbjarne rolfbjarne deleted the 7.0.1xx-rc-skip-ilgen_init branch August 29, 2022 08:55
rolfbjarne added a commit to rolfbjarne/macios that referenced this pull request Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

not-notes-worthy Ignore for release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants