Skip to content

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Feb 13, 2023

This pull request updates the following dependencies

From https://github.com/dotnet/installer

  • Subscription: 9a2944cb-7dee-4bf2-a65c-08dabd10ae64
  • Build: 20230306.1
  • Date Produced: March 6, 2023 10:15:46 AM UTC
  • Commit: 51e06f6931e859f56564556fa6ba519761fa7141
  • Branch: refs/heads/main

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

  • Coherency Updates:
    • Microsoft.NET.ILLink.Tasks: from 8.0.0-preview.2.23107.1 to 8.0.0-preview.2.23127.4 (parent: Microsoft.Dotnet.Sdk.Internal)
    • Microsoft.AspNetCore.App.Ref: from 8.0.0-preview.2.23107.2 to 8.0.0-preview.3.23127.13 (parent: Microsoft.Dotnet.Sdk.Internal)
    • Microsoft.NETCore.App.Ref: from 8.0.0-preview.2.23107.1 to 8.0.0-preview.2.23127.4 (parent: Microsoft.Dotnet.Sdk.Internal)
    • Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100-preview.2: from 8.0.0-preview.2.23081.3 to 8.0.0-preview.2.23113.1 (parent: Microsoft.NETCore.App.Ref)

…230213.1

Microsoft.Dotnet.Sdk.Internal
 From Version 8.0.100-preview.2.23108.2 -> To Version 8.0.100-preview.2.23113.1
@github-actions
Copy link
Contributor

github-actions bot commented Feb 13, 2023

.net ChangeLog for #17518

Level 1

Level 2

Generated using https://github.com/spouliot/dotnet-tools/tree/master/changelog

@rolfbjarne
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🔥 [PR Build] Build failed 🔥

Build failed for the job 'Build packages'

Pipeline on Agent
Hash: $(GIT_HASH) [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🔥 [PR Build] Build failed 🔥

Build failed for the job 'Detect API changes'

Pipeline on Agent
Hash: $(GIT_HASH) [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🔥 Unable to find the contents for the comment: D:\a\1\s\change-detection\results\gh-comment.md does not exist :fire

Pipeline on Agent
Hash: 131bc9ee09bb8b88a0ba07f46f651212904f5f98 [PR build]

dotnet-maestro bot and others added 2 commits February 14, 2023 13:51
…230213.3

Microsoft.Dotnet.Sdk.Internal
 From Version 8.0.100-preview.2.23108.2 -> To Version 8.0.100-preview.2.23113.3
@rolfbjarne
Copy link
Member

rolfbjarne commented Feb 15, 2023

@marek-safar @sbomer there doesn't seem to be a version of the Microsoft.NET.ILLink package with the runtime versioning (8.0.0-preview.x.y.z), they're all of the old style (8.0.100-x.y.z):

https://dev.azure.com/dnceng/public/_artifacts/feed/dotnet8/NuGet/Microsoft.NET.ILLink/versions/8.0.100-1.23067.1

vs

https://dev.azure.com/dnceng/public/_artifacts/feed/dotnet8/NuGet/Microsoft.NET.ILLink.Tasks/versions/8.0.0-preview.2.23114.2

This is a problem because the latest Microsoft.NET.ILLink package (which we use as a ref pack for illink.dll), contains an illink.dll with assembly version of 8.0.100:

packages/microsoft.net.illink/8.0.100-1.22608.1/ref/net7.0/illink.dll (MD5: 348E615E37AA1B6A5899F63C4CC18EB8) illink, Version=8.0.100.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35

while the one loaded during the build has assembly version of 8.0.100:

packages/microsoft.net.illink.tasks/8.0.0-preview.2.23107.1/tools/net8.0/illink.dll (MD5: E5286F48E52751A95281FE7037931F89) illink, Version=8.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35:

which means that our dotnet-linker.dll references illink.dll 8.0.100, and won't load during the build:

builds/downloads/dotnet-sdk-8.0.100-preview.2.23113.3/packs/Microsoft.iOS.Sdk/16.2.294-ci.darc-net8-0-7cab95c6-f843-42c8-a8a6-7c7eaf811f0a/tools/dotnet-linker/dotnet-linker.dll (MD5: 8E8A60942A13DE322FC6C72F21B8DD04) dotnet-linker, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null:
    References:
        illink, Version=8.0.100.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35
        [...]

eventually failing the build with:

ILLink error IL1027: Custom step 'Xamarin.SetupStep' could not be found.

I'm guessing this is because of dotnet/installer#15484.

dotnet-maestro bot and others added 2 commits February 15, 2023 13:41
…230214.23

Microsoft.Dotnet.Sdk.Internal
 From Version 8.0.100-preview.2.23108.2 -> To Version 8.0.100-preview.2.23114.23
@sbomer
Copy link
Member

sbomer commented Feb 16, 2023

It looks like when we moved over the packaging logic to dotnet/runtime, we missed the Microsoft.NET.ILLink package: dotnet/runtime#79609. @ViktorHofer @tlakollo this package is needed because it contains a ref assembly with the APIs available to custom steps (illink plugins). Could one of you please take a look?

@rolfbjarne rolfbjarne added the do-not-merge Do not merge this pull request label Feb 16, 2023
dotnet-maestro bot and others added 2 commits February 16, 2023 13:45
…230215.18

Microsoft.Dotnet.Sdk.Internal
 From Version 8.0.100-preview.2.23108.2 -> To Version 8.0.100-preview.2.23115.18
dotnet-maestro bot and others added 4 commits February 17, 2023 13:30
…230217.1

Microsoft.Dotnet.Sdk.Internal
 From Version 8.0.100-preview.2.23108.2 -> To Version 8.0.100-preview.2.23117.1

Dependency coherency updates

Microsoft.NET.ILLink.Tasks,Microsoft.AspNetCore.App.Ref,Microsoft.NETCore.App.Ref,Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100-preview.2
 From Version 8.0.0-preview.2.23107.1 -> To Version 8.0.0-preview.2.23116.1 (parent: Microsoft.Dotnet.Sdk.Internal
…230217.18

Microsoft.Dotnet.Sdk.Internal
 From Version 8.0.100-preview.2.23108.2 -> To Version 8.0.100-preview.2.23117.18

Dependency coherency updates

Microsoft.NET.ILLink.Tasks,Microsoft.AspNetCore.App.Ref,Microsoft.NETCore.App.Ref,Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100-preview.2
 From Version 8.0.0-preview.2.23107.1 -> To Version 8.0.0-preview.2.23116.1 (parent: Microsoft.Dotnet.Sdk.Internal
dotnet-maestro bot and others added 7 commits February 22, 2023 13:31
…230221.17

Microsoft.Dotnet.Sdk.Internal
 From Version 8.0.100-preview.2.23108.2 -> To Version 8.0.100-preview.2.23121.17

Dependency coherency updates

Microsoft.NET.ILLink.Tasks,Microsoft.AspNetCore.App.Ref,Microsoft.NETCore.App.Ref,Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100-preview.2
 From Version 8.0.0-preview.2.23107.1 -> To Version 8.0.0-preview.2.23116.1 (parent: Microsoft.Dotnet.Sdk.Internal
…230222.9

Microsoft.Dotnet.Sdk.Internal
 From Version 8.0.100-preview.2.23108.2 -> To Version 8.0.100-preview.2.23122.9

Dependency coherency updates

Microsoft.NET.ILLink.Tasks,Microsoft.AspNetCore.App.Ref,Microsoft.NETCore.App.Ref,Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100-preview.2
 From Version 8.0.0-preview.2.23107.1 -> To Version 8.0.0-preview.2.23116.1 (parent: Microsoft.Dotnet.Sdk.Internal
…230223.10

Microsoft.Dotnet.Sdk.Internal
 From Version 8.0.100-preview.2.23108.2 -> To Version 8.0.100-preview.2.23123.10

Dependency coherency updates

Microsoft.NET.ILLink.Tasks,Microsoft.AspNetCore.App.Ref,Microsoft.NETCore.App.Ref,Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100-preview.2
 From Version 8.0.0-preview.2.23107.1 -> To Version 8.0.0-preview.2.23123.4 (parent: Microsoft.Dotnet.Sdk.Internal
dotnet-maestro bot and others added 26 commits February 28, 2023 13:40
…230228.1

Microsoft.Dotnet.Sdk.Internal
 From Version 8.0.100-preview.2.23108.2 -> To Version 8.0.100-preview.3.23128.1

Dependency coherency updates

Microsoft.NET.ILLink.Tasks,Microsoft.AspNetCore.App.Ref,Microsoft.NETCore.App.Ref,Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100-preview.2
 From Version 8.0.0-preview.2.23107.1 -> To Version 8.0.0-preview.2.23127.4 (parent: Microsoft.Dotnet.Sdk.Internal
…230228.13

Microsoft.Dotnet.Sdk.Internal
 From Version 8.0.100-preview.2.23108.2 -> To Version 8.0.100-preview.3.23128.13

Dependency coherency updates

Microsoft.NET.ILLink.Tasks,Microsoft.AspNetCore.App.Ref,Microsoft.NETCore.App.Ref,Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100-preview.2
 From Version 8.0.0-preview.2.23107.1 -> To Version 8.0.0-preview.2.23127.4 (parent: Microsoft.Dotnet.Sdk.Internal
…230302.1

Microsoft.Dotnet.Sdk.Internal
 From Version 8.0.100-preview.2.23108.2 -> To Version 8.0.100-preview.3.23152.1

Dependency coherency updates

Microsoft.NET.ILLink.Tasks,Microsoft.AspNetCore.App.Ref,Microsoft.NETCore.App.Ref,Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100-preview.2
 From Version 8.0.0-preview.2.23107.1 -> To Version 8.0.0-preview.2.23127.4 (parent: Microsoft.Dotnet.Sdk.Internal
Fixes:

    System.NotSupportedException : Unsupported log file format. Latest supported version is 15, the log file has version 16.
…230302.8

Microsoft.Dotnet.Sdk.Internal
 From Version 8.0.100-preview.2.23108.2 -> To Version 8.0.100-preview.3.23152.8

Dependency coherency updates

Microsoft.NET.ILLink.Tasks,Microsoft.AspNetCore.App.Ref,Microsoft.NETCore.App.Ref,Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100-preview.2
 From Version 8.0.0-preview.2.23107.1 -> To Version 8.0.0-preview.2.23127.4 (parent: Microsoft.Dotnet.Sdk.Internal
…230303.7

Microsoft.Dotnet.Sdk.Internal
 From Version 8.0.100-preview.2.23108.2 -> To Version 8.0.100-preview.3.23153.7

Dependency coherency updates

Microsoft.NET.ILLink.Tasks,Microsoft.AspNetCore.App.Ref,Microsoft.NETCore.App.Ref,Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100-preview.2
 From Version 8.0.0-preview.2.23107.1 -> To Version 8.0.0-preview.2.23127.4 (parent: Microsoft.Dotnet.Sdk.Internal
…230304.2

Microsoft.Dotnet.Sdk.Internal
 From Version 8.0.100-preview.2.23108.2 -> To Version 8.0.100-preview.3.23154.2

Dependency coherency updates

Microsoft.NET.ILLink.Tasks,Microsoft.AspNetCore.App.Ref,Microsoft.NETCore.App.Ref,Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100-preview.2
 From Version 8.0.0-preview.2.23107.1 -> To Version 8.0.0-preview.2.23127.4 (parent: Microsoft.Dotnet.Sdk.Internal
…230306.1

Microsoft.Dotnet.Sdk.Internal
 From Version 8.0.100-preview.2.23108.2 -> To Version 8.0.100-preview.3.23156.1

Dependency coherency updates

Microsoft.NET.ILLink.Tasks,Microsoft.AspNetCore.App.Ref,Microsoft.NETCore.App.Ref,Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100-preview.2
 From Version 8.0.0-preview.2.23107.1 -> To Version 8.0.0-preview.2.23127.4 (parent: Microsoft.Dotnet.Sdk.Internal
Looks like we don't get this dependency from MSBuild.StructuredLogger anymore.
@rolfbjarne rolfbjarne merged commit 727a29d into net8.0 Mar 7, 2023
@dotnet-maestro dotnet-maestro bot deleted the darc-net8.0-7cab95c6-f843-42c8-a8a6-7c7eaf811f0a branch March 7, 2023 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge Do not merge this pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants