Bump Touch.Unit. #17819

rolfbjarne · 2023-03-16T09:41:30Z

New commits in spouliot/Touch.Unit:

xamarin/Touch.Unit@2836386 Always use NUnitTestAssemblyRunner's Load overload with the assembly name

Diff: https://github.com/spouliot/Touch.Unit/compare/564433f35c8ab6b7bb0709f83e1b81a89c406956..2836386d82ea935abfc9561f5fcbbe4fa65c4e22

New commits in spouliot/Touch.Unit: * xamarin/Touch.Unit@2836386 Always use NUnitTestAssemblyRunner's Load overload with the assembly name Diff: https://github.com/spouliot/Touch.Unit/compare/564433f35c8ab6b7bb0709f83e1b81a89c406956..2836386d82ea935abfc9561f5fcbbe4fa65c4e22

rolfbjarne · 2023-03-17T07:01:40Z

/azp run

azure-pipelines · 2023-03-17T07:02:01Z

Azure Pipelines successfully started running 1 pipeline(s).

vs-mobiletools-engineering-service2 · 2023-03-17T08:54:30Z

🔥 Tests failed catastrophically on VSTS: simulator tests - mac-binding-project 🔥

Not enough free space in the host.

Pipeline on Agent
Merge 7286e76 into f37c86b

vs-mobiletools-engineering-service2 · 2023-03-17T08:57:22Z

🔥 Tests failed catastrophically on VSTS: simulator tests - monotouch 🔥

Not enough free space in the host.

Pipeline on Agent
Merge 7286e76 into f37c86b

vs-mobiletools-engineering-service2 · 2023-03-17T09:00:03Z

🔥 Tests failed catastrophically on VSTS: simulator tests - xammac 🔥

Not enough free space in the host.

Pipeline on Agent
Merge 7286e76 into f37c86b

rolfbjarne · 2023-03-22T13:14:41Z

So these tests fail with:

Unhandled Exception:
System.BadImageFormatException: Invalid Image
File name: '/Users/rolf/Library/Developer/CoreSimulator/Devices/22EB43DD-2D03-4784-AACB-24F4C7F5A1AA/data/Containers/Bundle/Application/78F11EB6-327E-40F4-A33D-C088B4E3191A/testapp.app/testapp'
  at (wrapper managed-to-native) System.Reflection.Assembly.InternalGetAssemblyName(string,Mono.MonoAssemblyName&,string&)
  at System.Reflection.AssemblyName.GetAssemblyName (System.String assemblyFile) [0x00014] in /Library/Frameworks/Xamarin.iOS.framework/Versions/Current/src/Xamarin.iOS/mcs/class/corlib/System.Reflection/AssemblyName.cs:412
  at NUnit.Framework.Internal.NUnitLiteTestAssemblyBuilder.Load (System.String path) [0x00000] in /Users/rolf/work/maccore/main/xamarin-macios/builds/downloads/ios-release-Darwin-6dd9def57ce969ca04a0ecd9ef72c0a8f069112d/ios-sources/external/nunit-lite/NUnitLite-1.0.0/src/framework/Internal/NUnitLiteTestAssemblyBuilder.cs:100
  at NUnit.Framework.Internal.NUnitLiteTestAssemblyBuilder.Build (System.String assemblyName, System.Collections.IDictionary options) [0x00000] in /Users/rolf/work/maccore/main/xamarin-macios/builds/downloads/ios-release-Darwin-6dd9def57ce969ca04a0ecd9ef72c0a8f069112d/ios-sources/external/nunit-lite/NUnitLite-1.0.0/src/framework/Internal/NUnitLiteTestAssemblyBuilder.cs:78
  at MonoTouch.NUnit.UI.BaseTouchRunner.Load (System.String assemblyName, System.Collections.IDictionary settings) [0x00000] in /Users/rolf/work/maccore/main/xamarin-macios/external/Touch.Unit/NUnitLite/TouchRunner/TouchRunner.cs:615
  at MonoTouch.NUnit.UI.BaseTouchRunner.LoadSync () [0x00016] in /Users/rolf/work/maccore/main/xamarin-macios/external/Touch.Unit/NUnitLite/TouchRunner/TouchRunner.cs:169
  at MonoTouch.NUnit.UI.TouchRunner+<>c__DisplayClass5_0.<GetViewController>b__0 (System.Object v) [0x00000] in /Users/rolf/work/maccore/main/xamarin-macios/external/Touch.Unit/NUnitLite/TouchRunner/TouchRunner.cs:777
  at System.Threading.QueueUserWorkItemCallback.WaitCallback_Context (System.Object state) [0x0000d] in /Library/Frameworks/Xamarin.iOS.framework/Versions/Current/src/Xamarin.iOS/mcs/class/referencesource/mscorlib/system/threading/threadpool.cs:1370
  at System.Threading.ExecutionContext.RunInternal (System.Threading.ExecutionContext executionContext, System.Threading.ContextCallback callback, System.Object state, System.Boolean preserveSyncCtx) [0x00071] in /Library/Frameworks/Xamarin.iOS.framework/Versions/Current/src/Xamarin.iOS/mcs/class/referencesource/mscorlib/system/threading/executioncontext.cs:968
  at System.Threading.ExecutionContext.Run (System.Threading.ExecutionContext executionContext, System.Threading.ContextCallback callback, System.Object state, System.Boolean preserveSyncCtx) [0x00000] in /Library/Frameworks/Xamarin.iOS.framework/Versions/Current/src/Xamarin.iOS/mcs/class/referencesource/mscorlib/system/threading/executioncontext.cs:910
  at System.Threading.QueueUserWorkItemCallback.System.Threading.IThreadPoolWorkItem.ExecuteWorkItem () [0x00021] in /Library/Frameworks/Xamarin.iOS.framework/Versions/Current/src/Xamarin.iOS/mcs/class/referencesource/mscorlib/system/threading/threadpool.cs:1341
  at System.Threading.ThreadPoolWorkQueue.Dispatch () [0x00074] in /Library/Frameworks/Xamarin.iOS.framework/Versions/Current/src/Xamarin.iOS/mcs/class/referencesource/mscorlib/system/threading/threadpool.cs:899
  at ObjCRuntime.Runtime.ThreadPoolDispatcher (System.Func`1[TResult] callback) [0x00006] in /Users/rolf/work/maccore/main/xamarin-macios/src/ObjCRuntime/Runtime.cs:347
  at System.Threading._ThreadPoolWaitCallback.PerformWaitCallback () [0x00009] in /Library/Frameworks/Xamarin.iOS.framework/Versions/Current/src/Xamarin.iOS/mcs/class/referencesource/mscorlib/system/threading/threadpool.cs:1258

it's trying to load testapp.app/testapp as an assembly, which won't work, because that's a native executable (the corresponding managed assembly is testapp.app/testapp.exe)

rolfbjarne · 2023-03-22T13:22:00Z

@ivanpovazan something like this might work instead: https://gist.github.com/rolfbjarne/e3376c3a9543e542228935a1ea850b05, that should work because the code path that these failing tests use isn't changed (it's only changed for the NUNITLITE_NUGET case).

ivanpovazan · 2023-03-23T09:57:45Z

@ivanpovazan something like this might work instead: https://gist.github.com/rolfbjarne/e3376c3a9543e542228935a1ea850b05, that should work because the code path that these failing tests use isn't changed (it's only changed for the NUNITLITE_NUGET case).

Thanks for the suggestion, I agree that would be a better approach. The only thing I am wondering is whether the tests, that are using NUnitLiteTestAssemblyBuilder codepath, would be ran with NativeAOT?

…e assembly name (#117) Due to legacy Xamarin test failures: dotnet/macios#17819 (comment) The change should only affect tests and code paths which are using NUnit nuget package. Related to: #116

New commits in spouliot/Touch.Unit: * xamarin/Touch.Unit@b85fb26 Second attempt to use NUnitTestAssemblyRunner's Load overload with the assembly name Diff: https://github.com/spouliot/Touch.Unit/compare/2836386d82ea935abfc9561f5fcbbe4fa65c4e22..b85fb26cc07f5103a24ce41dc0819d15e6a5dbe6

vs-mobiletools-engineering-service2 · 2023-03-23T16:20:17Z

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 8fd82e1b83b0f90e3d8fb6dc5b7e07cf5ba9a080 [PR build]

vs-mobiletools-engineering-service2 · 2023-03-23T16:24:52Z

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: 8fd82e1b83b0f90e3d8fb6dc5b7e07cf5ba9a080 [PR build]

vs-mobiletools-engineering-service2 · 2023-03-23T16:25:29Z

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: 8fd82e1b83b0f90e3d8fb6dc5b7e07cf5ba9a080 [PR build]

vs-mobiletools-engineering-service2 · 2023-03-23T16:30:05Z

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)

~~iOS~~ (no change detected)
~~tvOS~~ (no change detected)
~~watchOS~~ (no change detected)
~~macOS~~ (no change detected)

NET (empty diffs)

~~iOS~~: (empty diff detected)
~~tvOS~~: (empty diff detected)
~~MacCatalyst~~: (empty diff detected)
~~macOS~~: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
watchOS: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)
Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist

Legacy Xamarin (stable) vs .NET

iOS: vsdrops gist
tvOS: vsdrops gist
macOS: vsdrops gist

✅ Generator diff

Generator diff is empty

Pipeline on Agent
Hash: 8fd82e1b83b0f90e3d8fb6dc5b7e07cf5ba9a080 [PR build]

vs-mobiletools-engineering-service2 · 2023-03-23T16:32:13Z

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMMINI-009.Ventura
Hash: 8fd82e1b83b0f90e3d8fb6dc5b7e07cf5ba9a080 [PR build]

vs-mobiletools-engineering-service2 · 2023-03-23T20:24:08Z

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 225 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 25 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 8fd82e1b83b0f90e3d8fb6dc5b7e07cf5ba9a080 [PR build]

rolfbjarne mentioned this pull request Mar 16, 2023

Adapt monotouch-test to work with NativeAOT #17774

Closed

This comment has been minimized.

Sign in to view

ivanpovazan mentioned this pull request Mar 23, 2023

Second attempt to use NUnitTestAssemblyRunner's Load overload with the assembly name xamarin/Touch.Unit#117

Merged

rolfbjarne added 2 commits March 23, 2023 15:46

Merge remote-tracking branch 'origin/main' into bump-nunit

8fd82e1

mandel-macaque approved these changes Mar 23, 2023

View reviewed changes

rolfbjarne marked this pull request as ready for review March 27, 2023 14:12

rolfbjarne merged commit 4645f3b into dotnet:main Mar 27, 2023

rolfbjarne deleted the bump-nunit branch March 27, 2023 14:14

Bump Touch.Unit. #17819

Bump Touch.Unit. #17819

Uh oh!

Conversation

rolfbjarne commented Mar 16, 2023

Uh oh!

This comment has been minimized.

rolfbjarne commented Mar 17, 2023

Uh oh!

azure-pipelines bot commented Mar 17, 2023

Uh oh!

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Mar 17, 2023

🔥 Tests failed catastrophically on VSTS: simulator tests - mac-binding-project 🔥

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 17, 2023

🔥 Tests failed catastrophically on VSTS: simulator tests - monotouch 🔥

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 17, 2023

🔥 Tests failed catastrophically on VSTS: simulator tests - xammac 🔥

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rolfbjarne commented Mar 22, 2023

Uh oh!

rolfbjarne commented Mar 22, 2023

Uh oh!

ivanpovazan commented Mar 23, 2023

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 23, 2023

💻 [CI Build] Windows Integration Tests passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 23, 2023

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 23, 2023

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 23, 2023

✅ API diff for current PR / commit

✅ API diff vs stable

✅ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 23, 2023

📚 [PR Build] Artifacts 📚

Packages generated

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 23, 2023

🚀 [CI Build] Test results 🚀

Test results

Tests counts

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants