Skip to content

[CoreMidi] Implement some of the missing CoreMIDI APIs. #22459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rolfbjarne wants to merge 19 commits into from
Closed

[CoreMidi] Implement some of the missing CoreMIDI APIs. #22459

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
aee0f26
[CoreMidi] Add a MidiObject.GetCheckedHandle method, and use it.
rolfbjarne Mar 26, 2025
db03d8a
[CoreMidi] Create MidiEventList and MidiEventListPacket, and bind Mid…
rolfbjarne Mar 24, 2025
c9638f7
[CoreMidi] Bind MIDIEndPoint[Get|Set]RefCons.
rolfbjarne Mar 26, 2025
c1404c0
[CoreMidi] Bind MIDIExternalDeviceCreate/MIDISetupAddExternalDevice/M…
rolfbjarne Mar 31, 2025
c36ed6b
MIDISetup - add/remove device. Missing tests.
rolfbjarne Mar 31, 2025
600c212
AddRemoveEndpoints - missing tests.
rolfbjarne Mar 31, 2025
1f7c94a
MIDIClientCreateWithBlock
rolfbjarne Apr 1, 2025
7886e64
New/RemoveEntity
rolfbjarne Apr 1, 2025
2ac388c
Create/DisposeDevice: missing tests
rolfbjarne Apr 1, 2025
e42213a
GetDriverDeviceList/GetDeviceIORunLoop. missing tests.
rolfbjarne Apr 2, 2025
53b26f6
MIDISendSysex: missing tests.
rolfbjarne Apr 2, 2025
803d1f3
MIDIDriverEnableMonitoring: missing tests.
rolfbjarne Apr 2, 2025
1457990
kMIDIDriverPropertyUsesSerial
rolfbjarne Apr 2, 2025
a5f3c9d
MIDIEventPacketSysexBytesForGroup
rolfbjarne Apr 2, 2025
f2208d7
MIDIDestinationCreateWithProtocol/MIDISourceCreateWithProtocol/MIDIIn…
rolfbjarne Apr 3, 2025
4cdc6d2
[CoreMidi] Add [NativeName] to a few types.
rolfbjarne May 21, 2025
7199c69
[CoreMidi] Add some API to tvOS.
rolfbjarne May 21, 2025
385ee30
Driver
rolfbjarne May 21, 2025
b38aef8
Auto-format source code
Jun 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
MIDISetup - add/remove device. Missing tests.
  • Loading branch information
@rolfbjarne
rolfbjarne committed Jun 4, 2025
commit c36ed6b1b0e47dd660c704c4f4f68872a0048636
24 changes: 24 additions & 0 deletions src/CoreMidi/MidiServices.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,8 +233,32 @@ public static nint DeviceCount {
#endif // !COREBUILD
}

/// <summary>This class consists of functions that customize the global state of the MIDI system.</summary>
public static class MidiSetup {
#if !COREBUILD
[DllImport (Constants.CoreMidiLibrary)]
unsafe extern static OSStatus MIDISetupAddDevice (MidiDeviceRef device);

/// <summary>Add a device to the current MIDI setup.</summary>
/// <param name="device">The device to add to the current MIDI setup.</param>
/// <returns>A status code that describes the result of the operation. This will be <see cref="MidiError.Ok" /> in case of success.</returns>
public static MidiError AddDevice (MidiDevice device)
{
return (MidiError) MIDISetupAddDevice (device.GetCheckedHandle ());
}


[DllImport (Constants.CoreMidiLibrary)]
unsafe extern static OSStatus MIDISetupRemoveDevice (MidiDeviceRef device);

/// <summary>Remove a device from the current MIDI setup.</summary>
/// <param name="device">The device to remove from the current MIDI setup.</param>
/// <returns>A status code that describes the result of the operation. This will be <see cref="MidiError.Ok" /> in case of success.</returns>
public static MidiError RemoveDevice (MidiDevice device)
{
return (MidiError) MIDISetupRemoveDevice (device.GetCheckedHandle ());
}

[DllImport (Constants.CoreMidiLibrary)]
unsafe extern static OSStatus MIDISetupAddExternalDevice (MidiDeviceRef device);

Expand Down
2 changes: 0 additions & 2 deletions tests/xtro-sharpie/api-annotations-dotnet/MacCatalyst-CoreMIDI.ignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@
!missing-pinvoke! MIDIGetDriverDeviceList is not bound
!missing-pinvoke! MIDIGetDriverIORunLoop is not bound
!missing-pinvoke! MIDISendSysex is not bound
!missing-pinvoke! MIDISetupAddDevice is not bound
!missing-pinvoke! MIDISetupRemoveDevice is not bound

# same as the above, we should bind all of them, these have been added on Xcode 12 beta 2
# https://github.com/dotnet/macios/issues/4452#issuecomment-660220392
Expand Down
2 changes: 0 additions & 2 deletions tests/xtro-sharpie/api-annotations-dotnet/iOS-CoreMIDI.ignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@
!missing-pinvoke! MIDIGetDriverDeviceList is not bound
!missing-pinvoke! MIDIGetDriverIORunLoop is not bound
!missing-pinvoke! MIDISendSysex is not bound
!missing-pinvoke! MIDISetupAddDevice is not bound
!missing-pinvoke! MIDISetupRemoveDevice is not bound

# same as the above, we should bind all of them, these have been added on Xcode 12 beta 2
# https://github.com/dotnet/macios/issues/4452#issuecomment-660220392
Expand Down
2 changes: 0 additions & 2 deletions tests/xtro-sharpie/api-annotations-dotnet/macOS-CoreMIDI.ignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@
!missing-pinvoke! MIDIGetDriverDeviceList is not bound
!missing-pinvoke! MIDIGetDriverIORunLoop is not bound
!missing-pinvoke! MIDISendSysex is not bound
!missing-pinvoke! MIDISetupAddDevice is not bound
!missing-pinvoke! MIDISetupRemoveDevice is not bound

# same as the above, we should bind all of them, these have been added on Xcode 12 beta 2
# https://github.com/dotnet/macios/issues/4452#issuecomment-660220392
Expand Down