Skip to content

[RGen] Use the PlatformSupportVersion for the supported and unsupported versions. #23842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mandel-macaque wants to merge 7 commits into
base: main
Choose a base branch
from
Open

[RGen] Use the PlatformSupportVersion for the supported and unsupported versions. #23842

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
14ac3c9
[RGen] Add a new type to track versions.
mandel-macaque Sep 17, 2025
382ee7e
Auto-format source code
Sep 17, 2025
46eb2d3
[RGen] Use the new PlatformSupportVersion in the builder.
mandel-macaque Sep 17, 2025
ec61da7
Auto-format source code
Sep 17, 2025
ef44958
[RGen] Use the PlatformSupportVersion for the supported and unsupport…
mandel-macaque Sep 18, 2025
47f3c28
Auto-format source code
Sep 18, 2025
06314f8
Merge branch 'main' into dev/mandel/platform-availability-kind
mandel-macaque Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Auto-format source code
  • Loading branch information
GitHub Actions Autoformatter committed Sep 18, 2025
commit 47f3c284c2609e3132fd6e2bbfab6ad1e2834a79
4 changes: 2 additions & 2 deletions src/rgen/Microsoft.Macios.Generator/Availability/PlatformAvailability.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,8 @@ public bool IsSupported {
// 1. The supported version is not null, either the default version or a specific one
// 2. The default version is not in the unsupported list
return SupportedVersion is not null
&& !unsupported.ContainsKey (PlatformSupportVersion.ImplicitDefault)
&& !unsupported.ContainsKey (PlatformSupportVersion.ExplicitDefault);
&& !unsupported.ContainsKey (PlatformSupportVersion.ImplicitDefault)
&& !unsupported.ContainsKey (PlatformSupportVersion.ExplicitDefault);
}
}

Expand Down
12 changes: 6 additions & 6 deletions src/rgen/Microsoft.Macios.Generator/Availability/PlatformSupportVersion.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ public PlatformSupportVersion (Version version) : this (version, SupportKind.Exp
}

/// <inheritdoc />
public int CompareTo(PlatformSupportVersion other)
public int CompareTo (PlatformSupportVersion other)
{
var versionComparison = Version.CompareTo (other.Version);
if (versionComparison != 0)
Expand All @@ -109,7 +109,7 @@ public int CompareTo(PlatformSupportVersion other)
/// <param name="left">The first <see cref="PlatformSupportVersion"/> to compare.</param>
/// <param name="right">The second <see cref="PlatformSupportVersion"/> to compare.</param>
/// <returns><c>true</c> if the left instance is less than the right instance; otherwise, <c>false</c>.</returns>
public static bool operator <(PlatformSupportVersion left, PlatformSupportVersion right)
public static bool operator < (PlatformSupportVersion left, PlatformSupportVersion right)
{
return left.CompareTo (right) < 0;
}
Expand All @@ -120,7 +120,7 @@ public int CompareTo(PlatformSupportVersion other)
/// <param name="left">The first <see cref="PlatformSupportVersion"/> to compare.</param>
/// <param name="right">The second <see cref="PlatformSupportVersion"/> to compare.</param>
/// <returns><c>true</c> if the left instance is greater than the right instance; otherwise, <c>false</c>.</returns>
public static bool operator >(PlatformSupportVersion left, PlatformSupportVersion right)
public static bool operator > (PlatformSupportVersion left, PlatformSupportVersion right)
{
return left.CompareTo (right) > 0;
}
Expand All @@ -131,7 +131,7 @@ public int CompareTo(PlatformSupportVersion other)
/// <param name="left">The first <see cref="PlatformSupportVersion"/> to compare.</param>
/// <param name="right">The second <see cref="PlatformSupportVersion"/> to compare.</param>
/// <returns><c>true</c> if the left instance is less than or equal to the right instance; otherwise, <c>false</c>.</returns>
public static bool operator <=(PlatformSupportVersion left, PlatformSupportVersion right)
public static bool operator <= (PlatformSupportVersion left, PlatformSupportVersion right)
{
return left.CompareTo (right) <= 0;
}
Expand All @@ -142,8 +142,8 @@ public int CompareTo(PlatformSupportVersion other)
/// <param name="left">The first <see cref="PlatformSupportVersion"/> to compare.</param>
/// <param name="right">The second <see cref="PlatformSupportVersion"/> to compare.</param>
/// <returns><c>true</c> if the left instance is greater than or equal to the right instance; otherwise, <c>false</c>.</returns>
public static bool operator >=(PlatformSupportVersion left, PlatformSupportVersion right)
public static bool operator >= (PlatformSupportVersion left, PlatformSupportVersion right)
{
return left.CompareTo(right) >= 0;
return left.CompareTo (right) >= 0;
}
}
2 changes: 1 addition & 1 deletion tests/rgen/Microsoft.Macios.Generator.Tests/Availability/PlatformAvailabilityTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ public void UnsupportedSeveralVersions (ApplePlatform platform, string [] versio

var availability = builder.ToImmutable ();
// get all the versions we added
var unsupported= availability.UnsupportedVersions.Keys
var unsupported = availability.UnsupportedVersions.Keys
.Select (x => x.Version).ToArray ();
// assert that the version is present
foreach (var v in versions) {
Expand Down
Loading