[msbuild] Remove the SdkBinPath and SdkUsrPath properties. #24450
Conversation
They're not necessary anymore (and probably hasn't for years).
There was a problem hiding this comment.
Pull request overview
This PR removes the obsolete SdkBinPath and SdkUsrPath MSBuild properties that are no longer necessary for building Apple platform projects. These properties previously tracked SDK binary and user paths, but modern Xcode builds no longer require these to be set explicitly as environment variables.
Key Changes
- Removed
SdkBinPathandSdkUsrPathproperties from MSBuild task classes - Removed associated environment variable assignments (
PATHandXCODE_DEVELOPER_USR_PATH) - Cleaned up error messages for validation of these now-removed paths
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| msbuild/Xamarin.MacDev.Tasks/Tasks/XcodeTool.cs | Removed SdkBinPath and SdkUsrPath required properties and their environment variable assignments |
| msbuild/Xamarin.MacDev.Tasks/Tasks/XcodeCompilerToolTask.cs | Removed SdkBinPath and SdkUsrPath properties and conditional environment variable assignments |
| msbuild/Xamarin.MacDev.Tasks/Tasks/DetectSdkLocation.cs | Removed output properties and validation logic for SDK bin/usr paths |
| msbuild/Xamarin.Shared/Xamarin.Shared.targets | Removed property bindings from IBTool, ACTool, and TextureAtlas task invocations |
| tests/msbuild/Xamarin.MacDev.Tasks.Tests/TaskTests/IBToolTaskTests.cs | Removed test code that computed and assigned the obsolete properties |
| tests/msbuild/Xamarin.MacDev.Tasks.Tests/TaskTests/ACToolTaskTest.cs | Removed test code that computed and assigned the obsolete properties |
| msbuild/Xamarin.Localization.MSBuild/MSBStrings.resx | Marked error message strings E0032 and E0085 as no longer used |
✅ [PR Build #9df603c] Build passed (Detect API changes) ✅Pipeline on Agent |
✅ [CI Build #9df603c] Build passed (Build packages) ✅Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
✅ [CI Build #9df603c] Build passed (Build macOS tests) ✅Pipeline on Agent |
💻 [CI Build #9df603c] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
💻 [CI Build #9df603c] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [CI Build #9df603c] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
💻 [CI Build #9df603c] Tests on macOS arm64 - Mac Sequoia (15) passed 💻✅ All tests on macOS arm64 - Mac Sequoia (15) passed. Pipeline on Agent |
💻 [CI Build #9df603c] Tests on macOS arm64 - Mac Tahoe (26) passed 💻✅ All tests on macOS arm64 - Mac Tahoe (26) passed. Pipeline on Agent |
🚀 [CI Build #9df603c] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 117 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
They're not necessary anymore (and probably hasn't been for years).