[Android] Removing TapGestureRecognizer with at least 2 taps causes Exception - fix#21714
Merged
Conversation
Contributor
|
Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Member
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
Why does it happen only with more than 2 taps ? |
jsuarezruiz
reviewed
Apr 9, 2024
| _ = App.WaitForElement("Item2"); | ||
| App.DoubleClick("Item2"); | ||
|
|
||
| //The test passes if no exception is thrown |
Contributor
There was a problem hiding this comment.
Could update a Label text double clicking and verify the updated text here; but without crash this is enough.
Contributor
Author
There was a problem hiding this comment.
Is this test enough then?
Contributor
Author
I suspect it is because of this constructor: |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
previously approved these changes
Jun 13, 2024
PureWeen
requested changes
Aug 16, 2024
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
PureWeen
approved these changes
Aug 17, 2024
samhouts
added
fixed-in-net9.0-nightly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues Fixed
Fixes #21437
before.mov
after.mov