Skip to content

fix: fix 22183 RadioButton checked value#22186

Merged
PureWeen merged 2 commits into
dotnet:mainfrom
maonaoda:bugfix/fix-22183
May 13, 2024
Merged

fix: fix 22183 RadioButton checked value#22186
PureWeen merged 2 commits into
dotnet:mainfrom
maonaoda:bugfix/fix-22183

Conversation

@maonaoda

@maonaoda maonaoda commented May 3, 2024

Copy link
Copy Markdown
Contributor

Description of Change

Issues Fixed

Fixes #22183

@maonaoda maonaoda requested a review from a team as a code owner May 3, 2024 08:45
@maonaoda maonaoda requested review from jsuarezruiz and mattleibow May 3, 2024 08:45
@dotnet-policy-service dotnet-policy-service Bot added the community ✨ Community Contribution label May 3, 2024
@jsuarezruiz jsuarezruiz added the area-controls-radiobutton RadioButton, RadioButtonGroup label May 3, 2024
@jsuarezruiz

Copy link
Copy Markdown
Contributor

/azp run

@dotnet-policy-service dotnet-policy-service Bot added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label May 3, 2024
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 3 pipeline(s).

Comment thread src/Controls/src/Core/RadioButton/RadioButtonGroup.cs Outdated
@PureWeen PureWeen requested review from dustin-wojciechowski and removed request for mattleibow May 3, 2024 20:28
format code

Co-authored-by: Dan Moseley <danmose@microsoft.com>
@jsuarezruiz

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 3 pipeline(s).

@dustin-wojciechowski

Copy link
Copy Markdown
Contributor

Looks good to me. Recorded the reproduction from the issue using the fix as well (doesn't show but my cursor is clicking between text and ellipses as well)

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-05-08.at.12.54.06.mp4

@Eilon Eilon removed the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label May 10, 2024
@PureWeen PureWeen merged commit 8b10f39 into dotnet:main May 13, 2024
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RadioButton with value cannot display selected state correctly

7 participants