Skip to content

Conversation

@JanProvaznik
Copy link
Member

@JanProvaznik JanProvaznik commented Oct 7, 2024

Fixes #10751

Context

Bootstrap is on by default, opt-in with arg /p:CreateBootstrap=true is unnecessary

Changes made

docs, CI: remove instances of CreateBootstrap=true

@JanProvaznik JanProvaznik requested a review from a team as a code owner October 7, 2024 08:53
Copy link
Member

@JanKrivanek JanKrivanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change!

I'm to blame for the wrong formulation of the bug.

CreateBootstrap property can only be used to opt-out from bootstrap creation. We still want to keep this behavior (and that mention in the doc)

Bootstrap is created by default - so explicit opt-in is rendundand and cinfusing - that's what we want to remove

@JanProvaznik JanProvaznik changed the title remove mentions of removed CreateBootstrap argument [docs] remove mention of opt-in CreateBootstrap Oct 7, 2024
@JanProvaznik JanProvaznik changed the title [docs] remove mention of opt-in CreateBootstrap remove CreateBootstrap opting-in Oct 7, 2024
Copy link
Member

@JanKrivanek JanKrivanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@JanProvaznik JanProvaznik merged commit a463e58 into dotnet:main Oct 7, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Documentation] Remove the mentions of CreateBootstrap property from our docs

3 participants