-
Notifications
You must be signed in to change notification settings - Fork 1.4k
remove CreateBootstrap opting-in #10760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove CreateBootstrap opting-in #10760
Conversation
JanKrivanek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the change!
I'm to blame for the wrong formulation of the bug.
CreateBootstrap property can only be used to opt-out from bootstrap creation. We still want to keep this behavior (and that mention in the doc)
Bootstrap is created by default - so explicit opt-in is rendundand and cinfusing - that's what we want to remove
documentation/wiki/Building-Testing-and-Debugging-on-Full-Framework-MSBuild.md
Show resolved
Hide resolved
JanKrivanek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Fixes #10751
Context
Bootstrap is on by default, opt-in with arg
/p:CreateBootstrap=trueis unnecessaryChanges made
docs, CI: remove instances of
CreateBootstrap=true