Ensure slash in PublishDir #11248
Merged
Ensure slash in PublishDir #11248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rainersigwald
approved these changes
Jan 9, 2025
SimaTian
approved these changes
Jan 13, 2025
Co-authored-by: Rainer Sigwald <[email protected]>
JanKrivanek
added a commit
that referenced
this pull request
Feb 7, 2025
This reverts commit 71e99de.
JanKrivanek
added a commit
that referenced
this pull request
Feb 7, 2025
### Context #11248 broke ClickOnce publishing - https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2359773 The breakage is caused by the 'NormalizePath' part - as it can change relative path to absolute. ### Changes made - reverted - added the original change, which just ensures the slash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #11057
Context
OutputPathis not guaranteed to end with slash when specified as a global property. So making sure the path composition using it is correct