Don't ngen Microsoft.IO.Redist for VS #11256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IO.Redist is a core part of VS now, so we shouldn't ngen it for the VS context--best case that's redundant work, worst case if we mismatch versions it might cause futher confusion.
Contributor
|
Hello @rainersigwald, I noticed that you’re changing an .swr file or any file under src/Package/MSBuild.VSSetup.. Please make sure to validate this change by an experimental VS insertion. This is accomplished by pushing to an exp/* branch, which requires write permissions to this repo. |
2 tasks
YuliiaKovalova
approved these changes
Jan 16, 2025
JanKrivanek
approved these changes
Jan 20, 2025
JanProvaznik
pushed a commit
that referenced
this pull request
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IO.Redist is a core part of VS now, so we shouldn't ngen it for the VS context--best case that's redundant work, worst case if we mismatch versions it might cause further confusion.
Internal PR: https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/602240
Validate: