Avoid synchronous I/O in BufferedReadStream #11379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanKrivanek
approved these changes
Feb 19, 2025
Member
JanKrivanek
left a comment
JanKrivanek
left a comment
There was a problem hiding this comment.
Looks good - thanks!
Please consider removing the code repetition in added ReadAsync func
AR-May
approved these changes
Feb 27, 2025
Member
AR-May
left a comment
AR-May
left a comment
There was a problem hiding this comment.
Overall, it looks good to me.
The usage of the preprocessor directives appears a bit messy. The FEATURE_APM constant relies on having a specific set of target frameworks in the repository. However, this dependency was not introduced in this PR, and I am unsure how to improve this PR without refactoring the usage of that constant in the whole repo. Let's proceed with the current implementation since it is still correct.
SimaTian
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Context
Changes Made
Testing
Notes