Skip to content

Fix test to take warning MSB5018 #11499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 12, 2025
Merged

Fix test to take warning MSB5018 #11499

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a5f2022
Update test to take warning MSB5018
JaynieBai Feb 25, 2025
d8dce66
revert test case name
JaynieBai Feb 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/Tasks.UnitTests/Exec_Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,9 +171,20 @@ public void Timeout()
Assert.Equal(expectedExitCode, exec.ExitCode);
((MockEngine)exec.BuildEngine).AssertLogContains("MSB5002");
int warningsCount = ((MockEngine)exec.BuildEngine).Warnings;
warningsCount.ShouldBe(1,
if (warningsCount == 1)
{
warningsCount.ShouldBe(1,
$"Expected 1 warning, encountered {warningsCount}: " + string.Join(",",
((MockEngine)exec.BuildEngine).WarningEvents.Select(w => w.Message)));
}
else
{
// Occasionally temp files fail to delete because of virus checkers, so generate MSB5018 warning
((MockEngine)exec.BuildEngine).AssertLogContains("MSB5018");
warningsCount.ShouldBe(2,
$"Expected 2 warnings, encountered {warningsCount}: " + string.Join(",",
((MockEngine)exec.BuildEngine).WarningEvents.Select(w => w.Message)));
}

// ToolTask does not log an error on timeout.
Assert.Equal(0, ((MockEngine)exec.BuildEngine).Errors);
Expand Down
Loading