Skip to content

Add BaseOutputPath to common targets #5238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rainersigwald merged 7 commits into from
Dec 7, 2020
Merged

Add BaseOutputPath to common targets #5238

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2f335b0
Add BaseOutputPath to common targets
Nirmal4G Apr 3, 2020
1e779a5
Use property functions within MSBuild namespace, wherever possible
Nirmal4G Apr 3, 2020
9a7012e
Fallback to legacy behavior for Configuration/Platform validation
Nirmal4G May 8, 2020
601ed38
Use 'Path.Combine' property function in place of using slashes to com…
Nirmal4G Aug 5, 2020
97bc2b5
Add tests for checking 'OutputPath' properties
Nirmal4G Aug 5, 2020
17c4944
Update comments on legacy Configuration/Platform check
Nirmal4G Dec 2, 2020
f7e97bd
Add a missing bracket
Nirmal4G Dec 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update comments on legacy Configuration/Platform check 
Adjust the wording to make it simple, brief and clear.

Co-Authored-By: Rainer Sigwald <[email protected]>

> Fixup with original commit when this patch is approved.
  • Loading branch information
@Nirmal4G
Nirmal4G committed Dec 2, 2020
commit 17c4944991fd23fda3e4ec2ec40e4ce86107cd1d
17 changes: 9 additions & 8 deletions src/Tasks/Microsoft.Common.CurrentVersion.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,8 +119,8 @@ Copyright (C) Microsoft Corporation. All rights reserved.
This is the full Output Path, and is derived from BaseOutputPath, if none specified
(eg. bin\Debug). If this property is overridden, then setting BaseOutputPath has no effect.

For projects loaded with MPFProj (Legacy project system):
This property is usually specified in the project file and is used to initialize OutDir.
For Legacy projects using only Common targets, this property is usually specified in the project file
and is used to initialize OutDir. Some SDKs including the .NET SDK derive this automatically.
OutDir and OutputPath are distinguished for legacy reasons, and OutDir should be used if at all possible.

BaseIntermediateOutputPath:
Expand Down Expand Up @@ -189,16 +189,17 @@ Copyright (C) Microsoft Corporation. All rights reserved.
</PropertyGroup>

<!--
For projects loaded with MPFProj (Legacy project system) that defines the properties per Configuration/Platform
combination by the IDE itself, the validation of an invalid Configuration/Platform is determined by the non-empty
value of the 'OutputPath' property specified under the IDE generated Configuration/Platform 'PropertyGroup' section.
For Legacy projects that define properties per Configuration/Platform combination, the validity of an
invalid combination is determined by the non-empty value of the 'OutputPath' property specified under
the IDE generated Configuration/Platform specific 'PropertyGroup' section.

If 'BaseOutputPath' is not specified, then, we should fallback to the existing behavior, as described above.
If 'BaseOutputPath' is specified, we can skip the validation, since, we assume the 'OutputPath' property
will be derived (e.g.: from the 'BaseOutputPath' property).
-->
<PropertyGroup Condition="'$(BaseOutputPathWasSpecified)' != 'true' and '$(_OutputPathWasMissing)' == 'true'">
<!--
When 'OutputPath' is missing or empty (along with non-existent 'BaseOutputPath') at this point means that
we're in legacy mode and we should assume the current Configuration/Platform combination as invalid.
When 'OutputPath' is missing or empty (along with non-existent 'BaseOutputPath') at this point means,
we're in legacy mode and we shall assume the current Configuration/Platform combination as invalid.
Whether this is considered an error or a warning depends on the value of $(SkipInvalidConfigurations).
-->
<_InvalidConfigurationError Condition=" '$(SkipInvalidConfigurations)' != 'true' ">true</_InvalidConfigurationError>
Expand Down