Skip to content

Support Common output via BuildDir and PublishDir #6105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Nirmal4G wants to merge 8 commits into from
Closed

Support Common output via BuildDir and PublishDir #6105

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3314811
Do use MSBuild's Path-specific property functions (Reverts #6245)
Nirmal4G Mar 25, 2021
2d97755
Format Comments in Common props, targets and tasks
Nirmal4G Apr 3, 2020
b66ebe1
Miscellaneous refactors in Common props, targets and tasks
Nirmal4G Apr 28, 2020
f07a0ad
Support Common output via BuildDir and PublishDir
Nirmal4G Apr 28, 2020
1806080
Append Project Name to build and publish
Nirmal4G May 2, 2020
1e8f99c
Move output paths' trailing slash and mismatch check its own target
Nirmal4G May 2, 2020
3cc87c6
Enable setting custom folder name for build & publish
Nirmal4G May 2, 2020
f4136af
Flow new output paths changes into tests
Nirmal4G Feb 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Enable setting custom folder name for build & publish 
Setting custom build and publish folder names is now enabled via 'BuildDirName' and 'PublishDirName'.
The defaults are 'build' for build directory and 'publish' for publish directory.
  • Loading branch information
@Nirmal4G
Nirmal4G committed Nov 5, 2021
commit 3cc87c64301368c16b0061d1dfbacdb6390b83dc
3 changes: 2 additions & 1 deletion src/Tasks/Microsoft.Common.CurrentVersion.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -481,7 +481,8 @@ Copyright (C) Microsoft Corporation. All rights reserved.

<!-- Output location for publish target. -->
<PropertyGroup>
<PublishDir>$([MSBuild]::EnsureTrailingSlash($([MSBuild]::ValueOrDefault('$(PublishDir)', 'publish'))))</PublishDir>
<PublishDirName Condition="'$(PublishDirName)' == ''">publish</PublishDirName>
<PublishDir>$([MSBuild]::EnsureTrailingSlash($([MSBuild]::ValueOrDefault('$(PublishDir)', '$(PublishDirName)'))))</PublishDir>
<PublishDir Condition="$([System.IO.Path]::IsPathRooted('$(PublishDir)')) and !$(PublishDir.StartsWith('$(MSBuildProjectDirectory)'))">$([MSBuild]::NormalizeDirectory('$(PublishDir)', '$(MSBuildProjectName)'))</PublishDir>
</PropertyGroup>

Expand Down
3 changes: 2 additions & 1 deletion src/Tasks/Microsoft.Common.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@ Copyright (C) Microsoft Corporation. All rights reserved.
and across multiple projects. Also for the $(MSBuildProjectExtensionsPath) to use it as a common root.
-->
<PropertyGroup>
<BuildDir>$([MSBuild]::EnsureTrailingSlash($([MSBuild]::ValueOrDefault('$(BuildDir)', 'build'))))</BuildDir>
<BuildDirName Condition="'$(BuildDirName)' == ''">build</BuildDirName>
<BuildDir>$([MSBuild]::EnsureTrailingSlash($([MSBuild]::ValueOrDefault('$(BuildDir)', '$(BuildDirName)'))))</BuildDir>
<BuildDir Condition="$([System.IO.Path]::IsPathRooted('$(BuildDir)')) and !$(BuildDir.StartsWith('$(MSBuildProjectDirectory)'))">$([MSBuild]::NormalizeDirectory('$(BuildDir)', '$(MSBuildProjectName)'))</BuildDir>
<_InitialBuildDir>$(BuildDir)</_InitialBuildDir>
</PropertyGroup>
Expand Down