Revert environment variable tracking #7766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Reverts environment-variable tracking from #7484.
We put in a change to, instead of logging all environment variables at the start of any diagnostic build (including in binlogs), only log those environment variables we actually use as part of properties. This was on by default. It hit a few speed bumps, hence multiple commits to revert here. The latest was that if Project System Tools (used to collect binlogs) is installed, builds fail half the time for any project.
Customer Impact
This reverts the change. Customers go back to seeing all environment variables at the start of a build, but they do not see builds failing if they have project system tools installed.
Regression?
Yes
Testing
We verified that this resolves the reported issue manually.
Risk
Low