Skip to content

Conversation

@rokonec
Copy link
Member

@rokonec rokonec commented Nov 3, 2022

Context

Test CacheTest2 was failing on local test runs build.cmd -test
It was caused by creating folder at C:\Users\}\... which is allowed only for admin elevated processes.

Changes Made

Problematic path created as subfolder of current path.
Only test was changed

Testing

Local run.

@MichalPavlik
Copy link
Member

nit: I suggest to rename this test. Something like WorksCorrectlyWithCurlyBraces :)

@rokonec
Copy link
Member Author

rokonec commented Nov 3, 2022

@rainersigwald Are we ok with renaming tests? We will lose history of runs for that tests in AzDO. Might not be as bad.

@rokonec rokonec self-assigned this Nov 3, 2022
@rokonec rokonec added the merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now. label Nov 3, 2022
@rokonec rokonec merged commit 9db3013 into dotnet:main Nov 4, 2022
@rainersigwald
Copy link
Member

@rainersigwald Are we ok with renaming tests? We will lose history of runs for that tests in AzDO. Might not be as bad.

I'd prefer to have a good name for now + the future; I rarely look at history for tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants