Localize strings of link error messages on non-Windows #8238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forgind
reviewed
Dec 13, 2022
danmoseley
reviewed
Dec 14, 2022
JaynieBai
changed the title
Forgind
added
the
merge-when-branch-open
Co-authored-by: Forgind <[email protected]>
lewing
reviewed
Mar 3, 2023
| { | ||
| hardLinkCreated = link(exitingFileName, newFileName) == 0; | ||
| errorMessage = hardLinkCreated ? null : "The link() library call failed with the following error code: " + Marshal.GetLastWin32Error(); | ||
| errorMessage = hardLinkCreated ? null : log.FormatResourceString("Copy.LinklibraryFailedPrefix", "link()", Marshal.GetLastWin32Error()); |
Member
There was a problem hiding this comment.
This resource doesn't seem to exist?
Contributor
There was a problem hiding this comment.
That's awkward. Will fix—thanks for pointing that out!
Forgind
added a commit
to Forgind/msbuild
that referenced
this pull request
Mar 3, 2023
dotnet#8238 added a reference to "Copy.LinkLibraryFailedPrefix" but didn't actually add that to our .resx. This adds it.
JaynieBai
pushed a commit
that referenced
this pull request
Mar 9, 2023
Fixes https://github.com/dotnet/msbuild/pull/8238/files#r1125001007 Context #8238 added a reference to "Copy.LinkLibraryFailedPrefix" but didn't actually add that to our .resx. This adds it. Changes Made Added a resource
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8231
Changes Made
Create resouse string and pass the log object as a parameter in the MakeHardLink function
Testing
Test locally