Skip to content

Correct success for /preprocess /targets builds #8908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 10, 2023
Merged

Correct success for /preprocess /targets builds #8908

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
62105ec
Correct success
Forgind Jun 16, 2023
da03b8c
Make isTargets not run if !success
Forgind Jun 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/MSBuild/XMake.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1148,7 +1148,7 @@ internal static bool BuildProject(
InitializationException.Throw(ResourceUtilities.FormatResourceStringStripCodeAndKeyword("ProjectUpgradeNeededToVcxProj", projectFile), null);
}

bool success = false;
bool success = true;

ProjectCollection projectCollection = null;
bool onlyLogCriticalEvents = false;
Expand Down Expand Up @@ -1292,7 +1292,7 @@ internal static bool BuildProject(
}
else
{
success = PrintTargets(projectFile, toolsVersion, globalProperties, targetsWriter, projectCollection);
success &= PrintTargets(projectFile, toolsVersion, globalProperties, targetsWriter, projectCollection);
}
}

Expand Down