Bring back eval results #9138
Merged
Bring back eval results #9138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@dfederm, any chance you could glance at the graph change I made here to make sure it looks legit to you? |
Contributor
Looks more or less like what we brainstormed offline. Since there appears to be an e2e test gap for graph, consider running a test build with |
Contributor
Author
|
I manually built my test project, and I got all the properties/items/etc. I wanted regardless of graph 🙂 |
Contributor
Author
|
(Building it normally with and without graph also worked) |
rainersigwald
approved these changes
Aug 25, 2023
ladipro
reviewed
Aug 28, 2023
rainersigwald
force-pushed
the
bring-back-eval-results
branch
from
4d7fdb3 to
6f528f9
Compare
YuliiaKovalova
approved these changes
Aug 30, 2023
MichalPavlik
approved these changes
Aug 30, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still working on final testing.Tested building a simple project with and without graph and with and without specifying properties/targets/items, and it works.
Tried building a slnf (that should fail if I specify any properties/targets/items) without any of those but with and without graph, and it succeeded.
First commit just reverts the revert.
Second commit attempts to fix it.
Third commit really fixes it.
Fourth commit tweaks a test.
Fifth commit tightens the access to the graph and ensures sln/slnf graph builds aren't affected.