Skip to content

Conversation

@Forgind
Copy link
Contributor

@Forgind Forgind commented Oct 18, 2023

Fixes #9339

Context

We need the built project to get the post-build results from it when using get* switches. They were almost always retained, but we didn't keep them if "RestoreOnly" was true. This fixes that.

Changes Made

Save project when only restoring.

Testing

Tweaked a unit test to cover this case.

Notes

Copy link
Member

@JanKrivanek JanKrivanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@rainersigwald rainersigwald enabled auto-merge (squash) October 19, 2023 15:31
@rainersigwald rainersigwald merged commit 221fd2e into dotnet:main Oct 19, 2023
@Forgind Forgind deleted the restore-getproperty branch October 19, 2023 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Build failed. Properties, Items, and Target results cannot be obtained. See details in stderr above.

3 participants