WriteJson nullable valuetype benchmarks #1632
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layomia
reviewed
Jan 21, 2021
Member
|
@eiriktsarpalis could you perhaps review this? going through old PR's and perhaps we can merge this. I'll rerun CI |
Member
|
It looks like some of these concerns were addressed by a later PR. I think we could just close this one. Don't have permissions to close it myself. |
Member
|
closing then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a couple new cases to the WriteJson benchmark suite from dotnet/runtime#46788.
/cc @steveharter