Skip to content
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Apply suggestions from code review
  • Loading branch information
adamsitnik authored Feb 9, 2022
commit 5b0dc382d052a653871f99ebdf4d5f2d2de6e7d6
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ public class ColdStartSerialization<T>

private T _value;
private readonly JsonSerializerOptions _defaultOptions = new JsonSerializerOptions();
private readonly JsonStringEnumConverter _converter = new();
private readonly JsonStringEnumConverter _converter = new JsonStringEnumConverter();

[GlobalSetup]
public void Setup()
Expand All @@ -26,20 +26,20 @@ public void Setup()
RoundtripSerialization(_defaultOptions);
}

private void RoundtripSerialization(JsonSerializerOptions options)
private T RoundtripSerialization(JsonSerializerOptions options)
{
string json = JsonSerializer.Serialize(_value, options);
JsonSerializer.Deserialize<T>(json, options);
return JsonSerializer.Deserialize<T>(json, options);
}

[Benchmark]
public void CachedDefaultOptions() => RoundtripSerialization(_defaultOptions);
public T CachedDefaultOptions() => RoundtripSerialization(_defaultOptions);

[Benchmark]
public void NewDefaultOptions() => RoundtripSerialization(new());
public T NewDefaultOptions() => RoundtripSerialization(new JsonSerializerOptions());

[Benchmark]
public void NewCustomizedOptions() =>
public T NewCustomizedOptions() =>
RoundtripSerialization(
new JsonSerializerOptions {
AllowTrailingCommas = true,
Expand All @@ -49,7 +49,7 @@ public void NewCustomizedOptions() =>
});

[Benchmark]
public void NewCustomConverter() =>
public T NewCustomConverter() =>
RoundtripSerialization(
new JsonSerializerOptions
{
Expand All @@ -58,7 +58,7 @@ public void NewCustomConverter() =>
});

[Benchmark]
public void NewCachedCustomConverter() =>
public T NewCachedCustomConverter() =>
RoundtripSerialization(
new JsonSerializerOptions
{
Expand Down